Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo] Simplify MetaData delete API #3091

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Sep 9, 2024

This PR adds 2 changes:

  1. Fixes an issue with valueStrippedHtml by switching to using HtmlUtils#fastStripHtml from the utils library, the issue was discussed here.
  2. Simplifies the update request by requiring only the ids of the deleted items instead of the full item, this will allow for a better usage in the app.
Testing

There is nothing really to test here, as these are just minor changes, so code review should be enough, but feel free to test the following if needed:

  1. The custom fields screen in the example app (can be accessed from Woo -> Orders -> View Custom Fields)
  2. This WCAndroid PR steps.

@hichamboushaba hichamboushaba changed the title [Woo] Metadata few improvements [Woo] Metadata two improvements Sep 9, 2024
@hichamboushaba hichamboushaba changed the title [Woo] Metadata two improvements [Woo] Metadata few improvements Sep 9, 2024
@hichamboushaba hichamboushaba changed the title [Woo] Metadata few improvements [Woo] Simplify MetaData delete API Sep 9, 2024
@hichamboushaba hichamboushaba marked this pull request as ready for review September 9, 2024 17:18
@irfano irfano self-assigned this Sep 10, 2024
Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the WCAndroid. LGTM! 👍🏻 I'm not merging now, since you might want to make a change for my comment.

@hichamboushaba hichamboushaba merged commit c35b836 into trunk Sep 11, 2024
13 checks passed
@hichamboushaba hichamboushaba deleted the woo/metadata-few-improvements branch September 11, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants