Issue/12563 delete custom fields

[hichamboushaba]

Closes: #12563

Description

This PR adds support for deleting custom fields.

Steps to reproduce

1. Open wp-admin, and add at least one custom field to an order.
2. Open the order in the app.
3. Tap on "View custom fields"
4. Open an existing custom field.
5. Tap on the overflow menu button.
6. Tap on Delete button.

Testing information

1. Test the delete flow for an existing field.
2. Test the delete flow for a new non-saved field.
3. Test the undo SnackBar.
4. Test saving changes after deleting some items.

The tests that have been performed

Same as above.

Images/gif

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 20.4. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	2e53f06
	Direct Download	woocommerce-wear-prototype-build-pr12566-2e53f06.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	2e53f06
	Direct Download	woocommerce-prototype-build-pr12566-2e53f06.apk

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 40.61%. Comparing base (75e5ead) to head (2e53f06).
Report is 11 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...merce/android/ui/compose/component/OverflowMenu.kt	0.00%	6 Missing ⚠️
...roid/ui/customfields/list/CustomFieldsViewModel.kt	84.00%	2 Missing and 2 partials ⚠️
...customfields/editor/CustomFieldsEditorViewModel.kt	80.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #12566      +/-   ##
============================================
+ Coverage     40.60%   40.61%   +0.01%     
- Complexity     5677     5680       +3     
============================================
  Files          1228     1228              
  Lines         69062    69091      +29     
  Branches       9568     9572       +4     
============================================
+ Hits          28044    28064      +20     
- Misses        38437    38444       +7     
- Partials       2581     2583       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[irfano]

LGTM! 👍🏻 Works well! I added a comment and will approve and merge after you respond to it.

[irfano]

Good job! LGTM! You'll probably do, but as a reminder, don't forget to add RELEASE NOTES in one of your PRs for the custom fields feature.

[hichamboushaba]

You'll probably do, but as a reminder, don't forget to add RELEASE NOTES in one of your PRs for the custom fields feature.

Thanks @irfano for the reminder, what we do generally when working on a feature that's behind a feature flag, is that we add the release notes entry in the PR that enables or removes the feature flag, so that it's not announced before we release it.