-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
대시보드 내가 제출한 디스커션 구현 (issue #482) #484
Open
brgndyy
wants to merge
10
commits into
dev
Choose a base branch
from
feat/#482
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
28f018e
feat: 수정사항 재반영
brgndyy cb5a0f5
feat: api 함수 생성
brgndyy 4bc0812
refactor: 쓰지 않는 페이지 삭제
brgndyy 0b0bc9d
fix: 린트 에러 수정
brgndyy 54cf926
fix: 빌드 에러 수정
brgndyy 276e5d4
fix: 빌드 에러 수정
brgndyy cb4f8c6
fix: 불필요한 콘솔 삭제
brgndyy f4f1d77
refactor: 쿼리키 분리
brgndyy a15afb8
refactor: 쿼리키 구체화
brgndyy e31049f
Merge branch 'dev' into feat/#482
brgndyy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import { develupAPIClient } from './clients/develupClient'; | ||
import type { DashboardDiscussion, DashboardDiscussionComment } from '@/types/dashboard'; | ||
import { PATH } from './paths'; | ||
|
||
export const getDashboardDiscussion = async () => { | ||
const { data } = await develupAPIClient.get<DashboardDiscussion>(PATH.dashboardDiscussion); | ||
|
||
return data; | ||
}; | ||
|
||
export const getDashboardDiscussionComments = async () => { | ||
const { data } = await develupAPIClient.get<DashboardDiscussionComment>( | ||
PATH.dashboardDiscussionComment, | ||
); | ||
|
||
return data; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
frontend/src/components/DashBoard/DashboardDiscussion/DashboardDiscussion.styled.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
import { styled } from 'styled-components'; | ||
import { Link } from 'react-router-dom'; | ||
|
||
export const HashTagWrapper = styled.div` | ||
display: flex; | ||
margin-bottom: 0.5rem; | ||
`; | ||
|
||
export const HashTag = styled.span<{ $isTitle?: boolean }>` | ||
padding: 0.5rem 0.8rem; | ||
border-radius: 2rem; | ||
margin-right: 0.7rem; | ||
background-color: ${(props) => (props.$isTitle ? 'var(--danger-50)' : 'var(--primary-50)')}; | ||
`; | ||
|
||
export const ImageWrapper = styled.div` | ||
width: 4.2rem; | ||
height: 4.2rem; | ||
border: 0.1rem solid var(--grey-400); | ||
border-radius: 50%; | ||
`; | ||
|
||
export const Image = styled.img` | ||
border-radius: 50%; | ||
width: 100%; | ||
height: 100%; | ||
`; | ||
|
||
export const Container = styled.div` | ||
width: 67.4rem; | ||
height: 100%; | ||
`; | ||
|
||
export const DiscussionWrapper = styled(Link)` | ||
height: 8.5rem; | ||
border-radius: 2.8rem; | ||
background: ${(props) => props.theme.colors.white}; | ||
box-shadow: ${(props) => props.theme.boxShadow.shadow04}; | ||
padding: 14px 34px 14px 34px; | ||
display: flex; | ||
margin-top: 3rem; | ||
margin-bottom: 1.5rem; | ||
cursor: pointer; | ||
`; | ||
|
||
export const CommentCountWrapper = styled.div` | ||
margin-left: 2.8rem; | ||
display: flex; | ||
justify-content: center; | ||
align-items: center; | ||
`; | ||
|
||
export const ImageCommentWrapper = styled.div` | ||
display: flex; | ||
justify-content: center; | ||
align-items: center; | ||
`; | ||
|
||
export const TextWrapper = styled.div` | ||
display: flex; | ||
flex-direction: column; | ||
min-width: 50rem; | ||
`; | ||
|
||
export const CommentText = styled.span` | ||
${(props) => props.theme.font.body} | ||
margin-bottom: 0.6rem; | ||
white-space: nowrap; | ||
overflow: hidden; | ||
text-overflow: ellipsis; | ||
`; | ||
|
||
export const SubText = styled.span` | ||
${(props) => props.theme.font.badge} | ||
color : var(--grey-400) | ||
`; | ||
|
||
export const CommentCountText = styled(SubText)` | ||
margin-left: 0.7rem; | ||
`; |
44 changes: 44 additions & 0 deletions
44
frontend/src/components/DashBoard/DashboardDiscussion/DiscussionItem.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import * as S from './DashboardDiscussion.styled'; | ||
import type { HashTag } from '@/types'; | ||
import CommentIcon from '@/assets/images/comment-count.svg'; | ||
|
||
interface DiscussionItemProps { | ||
id: number; | ||
mission: string; | ||
hashTags: HashTag[]; | ||
title: string; | ||
imageUrl: string; | ||
commentCount: number; | ||
} | ||
|
||
export default function DiscussionItem({ | ||
id, | ||
mission, | ||
hashTags, | ||
title, | ||
imageUrl, | ||
commentCount, | ||
}: DiscussionItemProps) { | ||
return ( | ||
<S.DiscussionWrapper to={`/discussions/${id}`}> | ||
<S.TextWrapper> | ||
<S.HashTagWrapper> | ||
<S.HashTag $isTitle>{mission}</S.HashTag> | ||
{hashTags.map((hashTag) => { | ||
return <S.HashTag key={hashTag.id}>{hashTag.name}</S.HashTag>; | ||
})} | ||
</S.HashTagWrapper> | ||
<S.CommentText>{title}</S.CommentText> | ||
</S.TextWrapper> | ||
<S.ImageCommentWrapper> | ||
<S.ImageWrapper> | ||
<S.Image src={imageUrl} width={22} height={22} /> | ||
</S.ImageWrapper> | ||
<S.CommentCountWrapper> | ||
<CommentIcon width={14} height={14} /> | ||
<S.CommentCountText>{commentCount}</S.CommentCountText> | ||
</S.CommentCountWrapper> | ||
</S.ImageCommentWrapper> | ||
</S.DiscussionWrapper> | ||
); | ||
} |
34 changes: 34 additions & 0 deletions
34
frontend/src/components/DashBoard/DashboardDiscussion/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import type { Discussion } from '@/types/dashboard'; | ||
import NoContent from '../DashBoardMissionList/NoContent'; | ||
import * as S from './DashboardDiscussion.styled'; | ||
import DiscussionItem from './DiscussionItem'; | ||
|
||
interface DashBoardDiscussionListProps { | ||
discussionList: Discussion[]; | ||
} | ||
|
||
export default function DashBoardDiscussionList({ discussionList }: DashBoardDiscussionListProps) { | ||
return ( | ||
<> | ||
{!discussionList.length ? ( | ||
<NoContent type="dashboardDiscussion" /> | ||
) : ( | ||
<S.Container> | ||
{discussionList.map((discussion) => { | ||
return ( | ||
<DiscussionItem | ||
key={discussion.id} | ||
id={discussion.id} | ||
hashTags={discussion.hashTags} | ||
title={discussion.title} | ||
mission={discussion.mission} | ||
imageUrl={discussion.member.imageUrl} | ||
commentCount={discussion.commentCount} | ||
/> | ||
); | ||
})} | ||
</S.Container> | ||
)} | ||
</> | ||
); | ||
} |
36 changes: 36 additions & 0 deletions
36
frontend/src/components/DashBoard/DiscussionComment/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import NoContent from '../DashBoardMissionList/NoContent'; | ||
import type { DiscussionComment } from '@/types/dashboard'; | ||
import MyComment from '../MyComments/MyComment'; | ||
import * as S from '../MyComments/MyComments.styled'; | ||
|
||
interface DiscussionCommentListProps { | ||
discussionCommentList: DiscussionComment[]; | ||
} | ||
|
||
export default function DiscussionCommentList({ | ||
discussionCommentList, | ||
}: DiscussionCommentListProps) { | ||
return ( | ||
<> | ||
{!discussionCommentList.length ? ( | ||
<NoContent type="comments" /> | ||
) : ( | ||
<S.Container> | ||
{discussionCommentList.map((discussionComment) => { | ||
return ( | ||
<MyComment | ||
key={discussionComment.id} | ||
type="discussions" | ||
contentId={discussionComment.discussionId} | ||
contentTitle={discussionComment.discussionTitle} | ||
createdAt={discussionComment.createdAt} | ||
content={discussionComment.content} | ||
contentCommentCount={discussionComment.discussionCommentCount} | ||
/> | ||
); | ||
})} | ||
</S.Container> | ||
)} | ||
</> | ||
); | ||
} |
26 changes: 18 additions & 8 deletions
26
frontend/src/components/DashBoard/MyComments/MyComment.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[A]
discussion List를 받아오는 쿼리의 key값이라 속성 값
discussion
을 복수형인discussions
로 하면 좋을 것 같은데 어떠실까요?!