-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
대시보드 내가 제출한 디스커션 구현 (issue #482) #484
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 버건디~ 앞서 열려있었던 PR 확인했습니다 ㅎㅎ
dashboardKeys
속성 관련 코멘트도 짧게 남겨놓았어요! 구조가 복잡한 부분 구현하시느라 고생많으셨습니다!!👍🏻
|
||
export const dashboardKeys = { | ||
default: ['dashboard'], | ||
discussion: () => [...dashboardKeys.default, 'discussions'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[A]
discussion List를 받아오는 쿼리의 key값이라 속성 값 discussion
을 복수형인 discussions
로 하면 좋을 것 같은데 어떠실까요?!
구현 요약
대시보드 내가 제출한 디스커션 구현 (isseu #440 )과 파일이 커밋 내용 동일합니다!
연관 이슈
참고
코드 리뷰에
RCA 룰
을 적용할 시 참고해주세요.