Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Fields: Local editing handling #13898

Closed
wants to merge 8 commits into from
Closed

Custom Fields: Local editing handling #13898

wants to merge 8 commits into from

Commits on Sep 9, 2024

  1. Add starting code for CustomFieldsListViewModel and update existing c… 

    …ode to use it.
    @hafizrahman
    hafizrahman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b3d5e38 View commit details
    Browse the repository at this point in the history

  2. Replace Editor button to say Done.

    @hafizrahman
    hafizrahman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ddda2f2 View commit details
    Browse the repository at this point in the history

  3. Add buttons list to save and add to list.

    @hafizrahman
    hafizrahman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c815d5d View commit details
    Browse the repository at this point in the history

  4. Add functionalities to edit and add local custom fields into the list.

    @hafizrahman
    hafizrahman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1341bcc View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Update logic for editing and adding new fields. 

    This includes support for cases like:
- Editing a field, then editing it again
- Adding new field, then editing that new field

The bulk of the logic is to ensure the content of `pendingChanges` to remain accurate during those cases.
    @hafizrahman
    hafizrahman committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9205192 View commit details
    Browse the repository at this point in the history

  2. Add unit tests for CustomFieldsListViewModel

    @hafizrahman
    hafizrahman committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    25b1402 View commit details
    Browse the repository at this point in the history

  3. Update visibility so that only hasChanges is public. 

    Also removes the struct for PendingChanges to simplify code.
    @hafizrahman
    hafizrahman committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2922806 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. lint fix

    @hafizrahman
    hafizrahman committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9b1e797 View commit details
    Browse the repository at this point in the history