-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Fields: Local editing handling #13898
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hafizrahman
changed the base branch from
trunk
to
feat/13493-custom-fields-edit-ui
September 9, 2024 13:40
Generated by 🚫 Danger |
This includes support for cases like: - Editing a field, then editing it again - Adding new field, then editing that new field The bulk of the logic is to ensure the content of `pendingChanges` to remain accurate during those cases.
Also removes the struct for PendingChanges to simplify code.
Version |
Version |
Closing this in favor of #14029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #13493
Please do not merge until target is
trunk
Description
The flow for editing/adding/deleting custom fields can be described as follows:
This PR handles the local editing behavior, by adding these:
CustomFieldsListViewModel
which handles the business logic.editedFields
andaddedFields
to store the pending edit and addition. It also hascombinedList
which is an array of the latest combined changes. Depending on the remote call design, any of these can be used to do the call.editField()
andaddField()
functions that can later be used when editing or adding a field.Not in this PR and will be added separately:
Steps to reproduce
The handling is not used anywhere in the app yet, so for now just check the code and ensure the unit tests also passes.
Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: