-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/12525 custom field creation #12531
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12531 +/- ##
============================================
+ Coverage 40.61% 40.62% +0.01%
- Complexity 5662 5665 +3
============================================
Files 1228 1228
Lines 68879 68901 +22
Branches 9541 9543 +2
============================================
+ Hits 27972 27991 +19
- Misses 38336 38338 +2
- Partials 2571 2572 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I didn't encounter any issues. 👍🏻 LGTM!
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/customfields/editor/CustomFieldsEditorScreen.kt
Closes: #12525 Closes: #12532
Description
This PR adds the following:
_
.Steps to reproduce
Testing information
_
The tests that have been performed
The above.
Images/gif
Screen_recording_20240905_162925.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: