Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starbound 1.0 Support #288

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Conversation

rubellyte
Copy link

@rubellyte rubellyte commented Jul 25, 2016

Includes fixes to player file reading and support for the new SBAsset format.
Known issues can be found here.

Callan Barrett and others added 13 commits January 25, 2016 12:35
- Use utf-8 when loading file assets (mods)
- Handle ship dialog for uninitialised players
- Handle null values in blueprint lists
- Suppress debug output from pillow
The playTime key was moved, this checks the old and new locations.
Read/write reagent bag, also defaults to new storage folder for player
files.
Add new bag, temporarily disabled hotbar editing, read new essentials
and armor slots, remove wieldable slots, modify UI for future hotbar
support.
Add crew size, remove enabled commands and command level.
medeor413 and others added 12 commits July 25, 2016 20:02
On a few items, Pillow errors with a "Could not identify image file" and
I cannot for the life of me figure out why, hence this workaround.
Temporary workaround for image loading error
To appease Codacy
Properly Capitalise Window Title
While player descriptions still exist in player files, players can no
longer be inspected, so it's useless.
I have no idea how well this works. Addresses #14.
Actually fixes #14, addresses #20
@Angelite191
Copy link

Uuuh, if remove those trailing whitespaces then recommit I'm sure all the checks will pass.

Hope this gets merged soon.

@Lknechtli
Copy link

One thing to keep in mind for a2507f6 : the fix works by just using the first image, because it appears that some item icons are constructed from several images which are combined. A good example is the starting sword: it is made from a hilt image and a blade image. If you want it to show up correctly, starcheat will need to support icons built from multiple images.

@rubellyte
Copy link
Author

Thanks for the heads-up, I'll look into that. Rendering icons from multiple parts has been something we've needed for a while, actually.

@Lknechtli
Copy link

oh yea, ran into that. as long as I didn't change the value, it didn't appear to break the save.

@rubellyte
Copy link
Author

Great, I'll patch that in shortly.

@kurisubrooks
Copy link
Contributor

Codacy PR check fails because of code written prior to our Pull Request. Should be good for merge at any time 👏

@kurisubrooks kurisubrooks mentioned this pull request Jul 29, 2016
@kurisubrooks
Copy link
Contributor

For those who come lurking looking for a nightly build, the latest version is currently a00f400.

chrmoritz and others added 5 commits July 30, 2016 19:06
remove py-starbound submodule
* switch from deprecated OptionParser to ArgumentParser
* default to verbose build
* added quite option (-q, —quite)
* also removed submodule documentation + ci command

Fixes wizzomafizzo#299
improved build.py + hide menubar icons on macOS
chrmoritz and others added 3 commits July 31, 2016 11:33
handle invalid JSON (empty, trailing comma) during asset import + style fixes
@DarkSasin
Copy link

hey my starcheat is crash but i dont know what it is.

Traceback (most recent call last):
File "C:\Python34-x64\lib\site-packages\cx_Freeze\initscripts\Console.py", line 27, in
File "build\starcheat.py", line 83, in
File "build\starcheat.py", line 80, in main
File "build\gui\mainwindow.py", line 154, in init
File "build\gui\utils.py", line 103, in check_index_valid
File "build\gui\utils.py", line 64, in build_assets_db
File "build\assets\core.py", line 127, in find_assets
File "build\assets\core.py", line 156, in scan_asset_folder
File "build\starbound\helpers.py", line 213, in open
File "build\starbound\helpers.py", line 220, in read_stream
File "build\starbound\btreedb4.py", line 119, in initialize
File "build\starbound\sbbf02.py", line 89, in initialize
AssertionError: Invalid file format

@kurisubrooks
Copy link
Contributor

kurisubrooks commented Aug 6, 2016

Starbound 1.0 is currently not supported in the main repo. Builds for 1.0
will be available soon.

@Xeveph Xeveph mentioned this pull request Oct 18, 2016
@rubellyte
Copy link
Author

rubellyte commented Dec 18, 2016

So, uh. The .exe builds aren't working for no reason I can see. Running the source works fine, but the .exe builds just crash without doing anything, no errors or any output. I honestly have no idea what to do about this. I've tried reverting all the changes, using older versions of dependencies to make sure an update didn't break them, I've really got nothing left to try.

@chrmoritz
Copy link
Collaborator

My guess is that the latest cx_freeze messed something up. The (not working) builds are now more than 3 times as big as before. @medeor413 Maybe pinning cx_freeze to an older known working version over here might help: https://github.com/wizzomafizzo/starcheat/blob/master/appveyor.yml#L28

@rubellyte
Copy link
Author

Well, that did it. I tried that locally, and it didn't work, but I don't think I'll question it too much.

@chrmoritz chrmoritz mentioned this pull request Dec 24, 2016
@OrangeJuice2404
Copy link

So is stearcheat fixed now and is there a download link? because this was super useful and is now dead. this was like the best thing in starbound. making custom weapons. Please fix or give a download link to a working version compatible with the current starbound, that being 1.3.2 or anything that would work with this version.

@mrexodia
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants