fix: Datadog integration leads to build failures - WPB-11936 #2153
Conversation
This reverts commit 465f8be.
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
Test Results 3 files 447 suites 5m 51s ⏱️ Results for commit d6b2dab. ♻️ This comment has been updated with latest results. |
it cannot be included in test target
netbe
changed the title
netbe
changed the title
netbe
requested review from
a team,
samwyndham,
El-Fitz,
KaterinaWire and
caldrian
and removed request for
a team
| .product(name: "DatadogTrace", package: "dd-sdk-ios") | ||
| ], | ||
| dependencies: datadogDependencies(), | ||
| path: "Sources/WireDatadog", |
There was a problem hiding this comment.
Did you consider making the path change instead of the source files? It might be easier to maintain 🤔
As a side note, if we take the file route perhaps this line is not necessary as I guess that is the default path
There was a problem hiding this comment.
from the doc it was saying here lies the directory and on the other one just filenames. I didn't play with this
| @@ -9,6 +9,7 @@ | |||
| } | |||
| ], | |||
| "defaultOptions" : { | |||
| "codeCoverage" : false, | |||
There was a problem hiding this comment.
Did you confirm that this was necessary?
There was a problem hiding this comment.
not completely sure, but I think it does not hurt to keep it disabled for now since we don't collect code coverage for now
This reverts commit 465f8be.
Issue
This PR attempts to fix develop tests by:
reverting PR fix: restore CallQualityControllerTests - WPB-11936 #2110: this is still an issue we will need to fix (ticket back to TODO)
separate WireDatadog and WireAnalytics:
WireAnalytics is still in SynEngine:
WireDatadog is in WireCommonComponents
The
canImportis removed entirely from WireCommonComponents so all datadog imports are within WireDatadogTesting