Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make WireAnalytics independent of WireDatadog - WPB-13904 #2150

Closed

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Nov 12, 2024

BugWPB-13904 [iOS] DataDog integration leads to build failures

Issue

WireDatadog was referenced as a dependency of WireAnalytics, but this is not really needed.
This PR moves one file from WireAnalytics into WireSyncEngine.
WireSyncEngine then references WireDatadog directly.
WireDatadog only conditionally imports Datadog.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Test Results

    3 files    448 suites   5m 20s ⏱️
3 133 tests 3 133 ✅ 0 💤 0 ❌
3 141 runs  3 141 ✅ 0 💤 0 ❌

Results for commit 8bb3545.

♻️ This comment has been updated with latest results.

@netbe
Copy link
Collaborator

netbe commented Nov 15, 2024

@caldrian I am closing this in favor of #2153

@netbe netbe closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants