-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more debug information for sync #WPB-11603 #3523
Open
damian-kaczmarek
wants to merge
5
commits into
release/candidate
Choose a base branch
from
chore/debug-information-sync
base: release/candidate
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−4
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
06a814d
chore: add more debug information for sync #WPB-11603
damian-kaczmarek de076b4
Merge branch 'refs/heads/release/candidate' into chore/debug-informat…
damian-kaczmarek c881cc7
CI Restart
damian-kaczmarek 0050514
checkout kalium branch
damian-kaczmarek 48da7e5
replace LifecycleLogger with CurrentScreenManager
damian-kaczmarek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
app/src/main/kotlin/com/wire/android/util/LifecycleLogger.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* | ||
* Wire | ||
* Copyright (C) 2024 Wire Swiss GmbH | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see http://www.gnu.org/licenses/. | ||
*/ | ||
|
||
@file:Suppress("StringTemplate") | ||
|
||
package com.wire.android.util | ||
|
||
import androidx.lifecycle.DefaultLifecycleObserver | ||
import androidx.lifecycle.LifecycleOwner | ||
import com.wire.android.appLogger | ||
|
||
import javax.inject.Inject | ||
import javax.inject.Singleton | ||
|
||
@Singleton | ||
class LifecycleLogger @Inject constructor() : DefaultLifecycleObserver { | ||
override fun onCreate(owner: LifecycleOwner) { | ||
super.onCreate(owner) | ||
appLogger.i("$TAG app onCreate") | ||
} | ||
|
||
override fun onStart(owner: LifecycleOwner) { | ||
super.onStart(owner) | ||
appLogger.i("$TAG app onStart") | ||
} | ||
|
||
override fun onResume(owner: LifecycleOwner) { | ||
super.onResume(owner) | ||
appLogger.i("$TAG app onResume") | ||
} | ||
|
||
override fun onPause(owner: LifecycleOwner) { | ||
super.onPause(owner) | ||
appLogger.i("$TAG app onPause") | ||
} | ||
|
||
override fun onStop(owner: LifecycleOwner) { | ||
super.onStop(owner) | ||
appLogger.i("$TAG app onStop") | ||
} | ||
|
||
override fun onDestroy(owner: LifecycleOwner) { | ||
super.onDestroy(owner) | ||
appLogger.i("$TAG app onDestroy") | ||
} | ||
|
||
private companion object { | ||
const val TAG = "LifecycleLogger" | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have
CurrentScreenManager
that also listen to lifecycle changes. I'd suggest to make those logs there as well to avoid duplication