Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more debug information for sync #WPB-11603 #3523

Open
wants to merge 5 commits into
base: release/candidate
Choose a base branch
from

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Oct 17, 2024

BugWPB-11603 [Android] App stuck on "decrypting messages"

What's new in this PR?

Issues

Wasn't able to reproduce the problem. Added some more debug information. Possibly we should improve the UI to inform user about networking problems. Or listen for our requests failing not being respond for a long time.

Dependencies (Optional)

More related changes in android: wireapp/kalium#3066


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Oct 17, 2024
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Oct 17, 2024
@damian-kaczmarek damian-kaczmarek changed the base branch from develop to release/candidate October 17, 2024 13:47
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 45.28%. Comparing base (2c80996) to head (48da7e5).
Report is 3 commits behind head on release/candidate.

Files with missing lines Patch % Lines
...tlin/com/wire/android/util/CurrentScreenManager.kt 20.00% 8 Missing ⚠️
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3523      +/-   ##
=====================================================
- Coverage              45.32%   45.28%   -0.04%     
=====================================================
  Files                    470      470              
  Lines                  15692    15705      +13     
  Branches                2626     2627       +1     
=====================================================
  Hits                    7112     7112              
- Misses                  7836     7848      +12     
- Partials                 744      745       +1     
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <0.00%> (ø)
...tlin/com/wire/android/util/CurrentScreenManager.kt 32.46% <20.00%> (-3.77%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c80996...48da7e5. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3523.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3523.apk is available for download

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

import javax.inject.Singleton

@Singleton
class LifecycleLogger @Inject constructor() : DefaultLifecycleObserver {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have CurrentScreenManager that also listen to lifecycle changes. I'd suggest to make those logs there as well to avoid duplication

Copy link

sonarcloud bot commented Oct 22, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3523.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants