-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(conversation): disable addMember on a one-on-one conversation with deleted account (WPB-10259) #3349
fix(conversation): disable addMember on a one-on-one conversation with deleted account (WPB-10259) #3349
Changes from 2 commits
419022e
2a93cd0
687a291
132274b
af52c37
dbe4ad8
de9d18c
3139c13
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99,7 +99,7 @@ fun GroupConversationDetailsTopBarCollapsing( | |
Text( | ||
text = title.ifBlank { | ||
if (isLoading) "" | ||
else UIText.StringResource(R.string.group_unavailable_label).asString() | ||
else UIText.StringResource(R.string.member_name_deleted_label).asString() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: is there a reason for the title change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, but it was showing different message for the same situation! e.g. when you see a conversation for a deleted user, and open the conversation details, you see the title is not available! so I decided to make it concise. |
||
}, | ||
overflow = TextOverflow.Ellipsis, | ||
maxLines = 1, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this to check if the name is not null and there is only one member, since legacy group conversations did allow empty names
this way, legacy groups will still continue to work as before.