-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(conversation): disable addMember on a one-on-one conversation with deleted account (WPB-10259) #3349
Merged
mchenani
merged 8 commits into
release/cycle-4.6
from
fix/disable-add-member-for-deleted-member-oneonone
Aug 28, 2024
Merged
fix(conversation): disable addMember on a one-on-one conversation with deleted account (WPB-10259) #3349
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
419022e
fix(conversation): disable addMember on a one-on-one conversation wit…
mchenani 2a93cd0
fix formatting
mchenani 687a291
check if the empty group does not have more than 1 member
mchenani 132274b
Merge branch 'release/cycle-4.6' into fix/disable-add-member-for-dele…
mchenani af52c37
Merge branch 'release/cycle-4.6' of https://github.com/wireapp/wire-a…
mchenani dbe4ad8
Merge remote-tracking branch 'origin/fix/disable-add-member-for-delet…
mchenani de9d18c
extracted logic to a function and added tests
mchenani 3139c13
Merge branch 'release/cycle-4.6' into fix/disable-add-member-for-dele…
MohamadJaara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
...otlin/com/wire/android/ui/common/bottomsheet/conversation/ConversationSheetContentTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
/* | ||
* Wire | ||
* Copyright (C) 2024 Wire Swiss GmbH | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see http://www.gnu.org/licenses/. | ||
*/ | ||
package com.wire.android.ui.common.bottomsheet.conversation | ||
|
||
import com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest.Companion.testGroup | ||
import com.wire.kalium.logic.data.conversation.Conversation | ||
import com.wire.kalium.logic.data.id.TeamId | ||
import kotlinx.coroutines.test.runTest | ||
import org.amshove.kluent.internal.assertEquals | ||
import org.junit.jupiter.api.Test | ||
|
||
class ConversationSheetContentTest { | ||
|
||
@Test | ||
fun givenTitleIsEmptyAndTheGroupSizeIsOne_whenCallingIsTheGroupAbandoned_returnsTrue() = runTest { | ||
val details = testGroup.copy(conversation = testGroup.conversation.copy(teamId = TeamId("team_id"))) | ||
|
||
val givenConversationSheetContent = ConversationSheetContent( | ||
title = "", | ||
conversationId = details.conversation.id, | ||
mutingConversationState = details.conversation.mutedStatus, | ||
conversationTypeDetail = ConversationTypeDetail.Group(details.conversation.id, details.isSelfUserCreator), | ||
selfRole = Conversation.Member.Role.Member, | ||
isTeamConversation = details.conversation.isTeamGroup(), | ||
isArchived = false, | ||
protocol = Conversation.ProtocolInfo.Proteus, | ||
mlsVerificationStatus = Conversation.VerificationStatus.NOT_VERIFIED, | ||
proteusVerificationStatus = Conversation.VerificationStatus.NOT_VERIFIED | ||
) | ||
val givenParticipantsCount = 1 | ||
|
||
assertEquals(true, givenConversationSheetContent.isAbandonedOneOnOneConversation(givenParticipantsCount)) | ||
} | ||
|
||
@Test | ||
fun givenTitleIsEmptyAndTheGroupSizeIsGtOne_whenCallingIsTheGroupAbandoned_returnsFalse() = runTest { | ||
val details = testGroup.copy(conversation = testGroup.conversation.copy(teamId = TeamId("team_id"))) | ||
|
||
val givenConversationSheetContent = ConversationSheetContent( | ||
title = "", | ||
conversationId = details.conversation.id, | ||
mutingConversationState = details.conversation.mutedStatus, | ||
conversationTypeDetail = ConversationTypeDetail.Group(details.conversation.id, details.isSelfUserCreator), | ||
selfRole = Conversation.Member.Role.Member, | ||
isTeamConversation = details.conversation.isTeamGroup(), | ||
isArchived = false, | ||
protocol = Conversation.ProtocolInfo.Proteus, | ||
mlsVerificationStatus = Conversation.VerificationStatus.NOT_VERIFIED, | ||
proteusVerificationStatus = Conversation.VerificationStatus.NOT_VERIFIED | ||
) | ||
val givenParticipantsCount = 3 | ||
|
||
assertEquals(false, givenConversationSheetContent.isAbandonedOneOnOneConversation(givenParticipantsCount)) | ||
} | ||
|
||
@Test | ||
fun givenTitleIsNotEmptyAndTheGroupSizeIsOne_whenCallingIsTheGroupAbandoned_returnsFalse() = runTest { | ||
val details = testGroup.copy(conversation = testGroup.conversation.copy(teamId = TeamId("team_id"))) | ||
|
||
val givenConversationSheetContent = ConversationSheetContent( | ||
title = "notEmpty", | ||
conversationId = details.conversation.id, | ||
mutingConversationState = details.conversation.mutedStatus, | ||
conversationTypeDetail = ConversationTypeDetail.Group(details.conversation.id, details.isSelfUserCreator), | ||
selfRole = Conversation.Member.Role.Member, | ||
isTeamConversation = details.conversation.isTeamGroup(), | ||
isArchived = false, | ||
protocol = Conversation.ProtocolInfo.Proteus, | ||
mlsVerificationStatus = Conversation.VerificationStatus.NOT_VERIFIED, | ||
proteusVerificationStatus = Conversation.VerificationStatus.NOT_VERIFIED | ||
) | ||
val givenParticipantsCount = 3 | ||
|
||
assertEquals(false, givenConversationSheetContent.isAbandonedOneOnOneConversation(givenParticipantsCount)) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is there a reason for the title change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but it was showing different message for the same situation! e.g. when you see a conversation for a deleted user, and open the conversation details, you see the title is not available! so I decided to make it concise.