fix: Catch excecption on Asset uploading [WPB-10700] #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
yamilmedina,
MohamadJaara,
vitorhugods and
ohassine
echoes-hq
bot
added
the
echoes: bugs
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
| } | ||
| } catch (e: IOException) { | ||
| kaliumLogger.e("Something went wrong when uploading the Asset Message. $e") | ||
| return Either.Left(EncryptionFailure.GenericEncryptionError) |
There was a problem hiding this comment.
here you can return a generic error and pass the exception to it
Suggested change
| return Either.Left(EncryptionFailure.GenericEncryptionError) | |
| return Either.Left(CoreFailure.Unknown(e)) |
Datadog ReportBranch report: ✅ 0 Failed, 3088 Passed, 107 Skipped, 13.69s Total Time |
|
yamilmedina
approved these changes
Sep 24, 2024
MohamadJaara
approved these changes
Sep 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
* fix: Catch excecption on Asset uploading * Review fixes
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
* fix: Catch excecption on Asset uploading * Review fixes Co-authored-by: boris <[email protected]> Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
FileNotFoundExceptionon sending asset message.Causes (Optional)
Couldn't reproduce it, or find out the actual reason.
Solutions
Wrap it to
try catchto at least not crash the app.