Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch exception on Asset uploading [WPB-10700] 🍒 #3030

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 25, 2024

BugWPB-10700 [Android] file not found when sending assets

This PR was automatically cherry-picked based on the following PR:

Original PR description:


What's new in this PR?

Issues

FileNotFoundException on sending asset message.

Causes (Optional)

Couldn't reproduce it, or find out the actual reason.

Solutions

Wrap it to try catch to at least not crash the app.

* fix: Catch excecption on Asset uploading

* Review fixes
@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: bugs Technical or functional defects in the product type: bug / fix 🐞 👕 size: S 🚨 Potential breaking changes labels Sep 25, 2024
@vitorhugods vitorhugods changed the title fix: Catch excecption on Asset uploading [WPB-10700] 🍒 fix: Catch exception on Asset uploading [WPB-10700] 🍒 Sep 25, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

Copy link
Contributor Author

github-actions bot commented Sep 25, 2024

Test Results

3 202 tests  ±0   3 095 ✅ ±0   3m 56s ⏱️ +3s
  551 suites ±0     107 💤 ±0 
  551 files   ±0       0 ❌ ±0 

Results for commit 53d70ed. ± Comparison against base commit 3d4468b.

♻️ This comment has been updated with latest results.

@vitorhugods vitorhugods added this pull request to the merge queue Sep 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (3d4468b) to head (53d70ed).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...om/wire/kalium/logic/data/asset/AssetRepository.kt 63.15% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3030      +/-   ##
===========================================
- Coverage    52.52%   52.52%   -0.01%     
===========================================
  Files         1301     1301              
  Lines        50043    50047       +4     
  Branches      4663     4663              
===========================================
+ Hits         26286    26287       +1     
- Misses       21884    21888       +4     
+ Partials      1873     1872       -1     
Files with missing lines Coverage Δ
...om/wire/kalium/logic/data/asset/AssetRepository.kt 86.42% <63.15%> (-1.81%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4468b...53d70ed. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/catch_exception_on_asset_uploading-cherry-pick
Commit report: f1ea7fe
Test service: kalium-jvm

✅ 0 Failed, 3095 Passed, 107 Skipped, 12.58s Total Time

Merged via the queue into develop with commit 6282928 Sep 25, 2024
20 of 21 checks passed
@vitorhugods vitorhugods deleted the fix/catch_exception_on_asset_uploading-cherry-pick branch September 25, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: bugs Technical or functional defects in the product 🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants