Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SetVideoSendStateUseCase (WPB-7114) #2670

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Mar 20, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Moving the logic of updating send state to a separate usecase.
Needed for wireapp/wire-android#2801

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Mar 20, 2024

Test Results

2 997 tests  +1   2 876 ✔️ +1   2m 54s ⏱️ +6s
   518 suites +1      121 💤 ±0 
   518 files   +1          0 ±0 

Results for commit 4fc22b9. ± Comparison against base commit 91c3be1.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
com.wire.kalium.logic.feature.call.usecase.UpdateVideoStateUseCaseTest ‑ givenAFlowOfEstablishedCallsThatContainsAnEstablishedCall_whenUseCaseInvoked_thenInvokeUpdateVideoState[jvm]
com.wire.kalium.logic.feature.call.usecase.UpdateVideoStateUseCaseTest ‑ givenAFlowOfEstablishedCallsThatContainsNonEstablishedCall_whenUseCaseInvoked_thenDoNotInvokeUpdateVideoState[jvm]
com.wire.kalium.logic.feature.call.usecase.video.SetVideoSendStateUseCaseTest ‑ givenVideoState_whenRunningUsecase_thenInvokeSetVideoSendStateOnce[jvm]
com.wire.kalium.logic.feature.call.usecase.video.UpdateVideoStateUseCaseTest ‑ givenAFlowOfEstablishedCallsThatContainsAnEstablishedCall_whenUseCaseInvoked_thenInvokeUpdateVideoState[jvm]
com.wire.kalium.logic.feature.call.usecase.video.UpdateVideoStateUseCaseTest ‑ givenAFlowOfEstablishedCallsThatContainsNonEstablishedCall_whenUseCaseInvoked_thenDoNotInvokeUpdateVideoState[jvm]

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 20, 2024

Datadog Report

All test runs b99c782 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2105 38 11.11s Link
kalium-jvm 0 0 0 2876 121 9m 18.04s Link

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this need to be cherry-picked into RC

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 58.71%. Comparing base (91c3be1) to head (4fc22b9).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2670      +/-   ##
=============================================
- Coverage      58.71%   58.71%   -0.01%     
  Complexity         7        7              
=============================================
  Files           1188     1189       +1     
  Lines          46512    46511       -1     
  Branches        4386     4384       -2     
=============================================
- Hits           27311    27310       -1     
- Misses         17241    17242       +1     
+ Partials        1960     1959       -1     
Files Coverage Δ
...ure/call/usecase/video/SetVideoSendStateUseCase.kt 100.00% <100.00%> (ø)
...ture/call/usecase/video/UpdateVideoStateUseCase.kt 60.00% <ø> (ø)
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c3be1...4fc22b9. Read the comment docs.

@ohassine ohassine added this pull request to the merge queue Mar 25, 2024
Merged via the queue into develop with commit c15c2f1 Mar 25, 2024
25 checks passed
@ohassine ohassine deleted the calling_video_not_streamed branch March 25, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants