Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SetVideoSendStateUseCase (WPB-7114) - cherrypick 4.4 #2839

Merged

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jun 24, 2024

cherry pick of


What's new in this PR?

Description

Moving the logic of updating send state to a separate usecase.
Needed for wireapp/wire-android#3125

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Jun 24, 2024

@yamilmedina yamilmedina added the cherry-pick PR is cherry-picking changes from another banch label Jun 24, 2024
Copy link
Contributor

github-actions bot commented Jun 24, 2024

Unit Test Results

       6 files         6 suites   6m 30s ⏱️
2 270 tests 2 252 ✔️ 18 💤 0

Results for commit 3908bf8.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jun 24, 2024

Datadog Report

All test runs efdcaef 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2154 120 1.02s Link
kalium-jvm 0 0 0 2271 98 2.72s Link

@yamilmedina yamilmedina merged commit dc607c7 into release/android-cycle-4.4.x Jun 25, 2024
18 checks passed
@yamilmedina yamilmedina deleted the fix/calling_video_not_streamed-4.4 branch June 25, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants