-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failure fetching federated certificate chain #2660
fix: failure fetching federated certificate chain #2660
Conversation
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/e2ei/E2EIRepository.kt
Show resolved
Hide resolved
logic/src/commonMain/kotlin/com/wire/kalium/logic/sync/slow/SlowSyncWorker.kt
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 2841 Passed, 123 Skipped, 8m 41s Wall Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2660 +/- ##
====================================================
Coverage ? 58.35%
Complexity ? 7
====================================================
Files ? 1176
Lines ? 46160
Branches ? 4380
====================================================
Hits ? 26935
Misses ? 17264
Partials ? 1961
Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Vitor Hugo Schwaab <[email protected]> Co-authored-by: Oussama Hassine <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Scenario
Given I am a User with E2EI enabled
And I have MLS conversations with federated users
And I get a E2EI certificate during login
When performing Slow Sync
What's happening
It fails during
JoinExternalMLSConversations
andResolveOneOnOneConversations
because CoreCrypto can't validate the identity of some users.I get completely stuck in "Waiting for Connection"
What should happen
It should join all existing MLS conversations and resolve one on ones.
I should not get stuck
Causes
Solutions
fetchFederationCertificates
during E2EI enrollmentTesting
Test Coverage
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.