-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failure fetching federated certificate chain #2661
fix: failure fetching federated certificate chain #2661
Conversation
…e-chain-cherry-pick
Test Results2 981 tests +1 2 860 ✔️ +1 2m 41s ⏱️ -1s Results for commit 5bf4a28. ± Comparison against base commit bb07ad1. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2661 +/- ##
=============================================
- Coverage 58.74% 58.74% -0.01%
Complexity 7 7
=============================================
Files 1189 1189
Lines 46287 46300 +13
Branches 4376 4377 +1
=============================================
+ Hits 27192 27199 +7
- Misses 17145 17148 +3
- Partials 1950 1953 +3
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Scenario
Given I am a User with E2EI enabled
And I have MLS conversations with federated users
And I get a E2EI certificate during login
When performing Slow Sync
What's happening
It fails during and because CoreCrypto can't validate the identity of some users.
I get completely stuck in Waiting for Connection
What should happen
It should join all existing MLS conversations and resolve one on ones.
I should not get stuck
Causes
Solutions
Testing
Test Coverage
PR Post Merge Checklist for internal contributors
References