fix: handle federation not enabled [WPB-5237] #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garzas
requested review from
typfel,
yamilmedina,
MohamadJaara,
vitorhugods and
saleniuk
|
Bad checkout, I will need to have only one commit from cherry-pick |
Garzas
force-pushed
the
fix/handle-federation-not-enabled
branch
from
21edd8f
to
9045d6e
Compare
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
Garzas
force-pushed
the
fix/handle-federation-not-enabled
branch
from
9045d6e
to
514105f
Compare
Codecov Report
@@ Coverage Diff @@
## release/candidate #2189 +/- ##
====================================================
Coverage ? 58.19%
Complexity ? 21
====================================================
Files ? 1010
Lines ? 37750
Branches ? 3437
====================================================
Hits ? 21967
Misses ? 14317
Partials ? 1466 Continue to review full report in Codecov by Sentry.
|
Garzas
force-pushed
the
fix/handle-federation-not-enabled
branch
from
514105f
to
c8be798
Compare
yamilmedina
approved these changes
Nov 6, 2023
vitorhugods
reviewed
Nov 6, 2023
Comment on lines
212
to
215
| verify(arrangement.userDetailsApi) | ||
| .suspendFunction(arrangement.userDetailsApi::getMultipleUsers) | ||
| .with(any()) | ||
| .wasInvoked(exactly = twice) |
There was a problem hiding this comment.
It would be nice to check that it invoked getMultipleUsers with the different inputs, instead of any() tiwce.
…p/kalium into fix/handle-federation-not-enabled
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
vitorhugods
approved these changes
Nov 8, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
One of client servers returns
probably when user tries to fetch other user data with different domain
Causes (Optional)
Because fetching users is during slow sync, when it returns error the entire slow sync is aborted and user is stuck on connecting
Solutions
Handle this error and try to fetch again only those users which have the same domain as self user