Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle federation not enabled [WPB-5237] #2207

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Nov 8, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry-pick from #2189

Issues

One of client servers returns

ErrorResponse(code=400, message=no federator configured, label=federation-not-enabled, cause=null)

probably when user tries to fetch other user data with different domain

Causes (Optional)

Because fetching users is during slow sync, when it returns error the entire slow sync is aborted and user is stuck on connecting

Solutions

Handle this error and try to fetch again only those users which have the same domain as self user

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Unit Test Results

   470 files  ±0     470 suites  ±0   2m 36s ⏱️ -48s
2 619 tests +1  2 515 ✔️ +1  104 💤 ±0  0 ±0 

Results for commit 0d0ee68. ± Comparison against base commit eb47fb6.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 8, 2023

Datadog Report

All test runs cd43fa8 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1976 42 6m 4.1s Link
kalium-jvm 0 0 0 2515 104 11m 26s Link

@codecov-commenter
Copy link

Codecov Report

Merging #2207 (0d0ee68) into develop (eb47fb6) will increase coverage by 0.01%.
The diff coverage is 72.22%.

@@              Coverage Diff              @@
##             develop    #2207      +/-   ##
=============================================
+ Coverage      57.98%   57.99%   +0.01%     
  Complexity        21       21              
=============================================
  Files           1070     1070              
  Lines          40641    40658      +17     
  Branches        3757     3759       +2     
=============================================
+ Hits           23564    23580      +16     
  Misses         15463    15463              
- Partials        1614     1615       +1     
Files Coverage Δ
.../wire/kalium/network/exceptions/KaliumException.kt 78.84% <100.00%> (+2.37%) ⬆️
...ire/kalium/network/exceptions/NetworkErrorLabel.kt 100.00% <ø> (ø)
...ire/kalium/network/api/base/model/ErrorResponse.kt 54.16% <0.00%> (ø)
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 20.66% <33.33%> (+0.32%) ⬆️
.../com/wire/kalium/logic/data/user/UserRepository.kt 60.65% <84.61%> (+1.34%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb47fb6...0d0ee68. Read the comment docs.

@Garzas Garzas added this pull request to the merge queue Nov 10, 2023
Merged via the queue into develop with commit 8e2301b Nov 10, 2023
17 checks passed
@Garzas Garzas deleted the fix/handle-federation-not-enabled-cherry-pick branch November 10, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants