Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archived: add new variant without overlay #2289

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Garneauma
Copy link
Contributor

@Garneauma Garneauma commented Nov 23, 2023

Added new Archived variant without overlay and updated documentation to new data-first template.

Closes #2276

@duboisp
Copy link
Member

duboisp commented Nov 27, 2023

Pre-approve upon review + testing + looping back with @nfrenette to see if this do align to fix its original issue.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed locally, work as expected.

This is a minor change.

  • Minor - Addition of a new design pattern for the archive banner
  • Patch - Refactoring of the CSS

@duboisp
Copy link
Member

duboisp commented Dec 7, 2023

Note: We did loopback with @nfrenette on this and @Garneauma updated this PR accordingly.

@duboisp duboisp changed the title Archived: Fixing scrollbar issue on smaller screens Archived: add new variant without overlay Dec 7, 2023
@duboisp duboisp merged commit 6f0de3e into wet-boew:master Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants