-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive notice update to fix issues with overlay #2276
Conversation
Notice without overlay, and width matching width of header.
Todo for wet-boew maintainer:
(ref num: bsd-27705) |
Removed inview related classes and attribute.
@nfrenette I have opened a new PR that fixes the scrollbar issues and hidden close button (#2289). The only issue left from your list is the keyboard accessible button. I intend to fix that in another PR in WET-BOEW. Here is a link to a demo of this fix: https://servicecanada.github.io/wet-boew-demos/gcweb-pr2289/sites/archived/archived-en.html Please let me know if this would be a suitable fix for your issues. |
Removed the overlay from the Archive notice, and the width now matches the width of header.
Instead of fixing the overlay and moving code around, we decided to remove the overlay entirely, so that we didn't have to fix the following 3 issues:
Issue 1: At around 800 pixel width, the overlay “x” button to close is not visible on certain devices.
Screenshot of missing close button
Screenshot of visible close button on smaller device/width
Screenshot of visible close button on larger device/width
Issue 2: Horizontal scroll bar around the same screen size where the close button disappears.