Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive notice update to fix issues with overlay #2276

Closed
wants to merge 11 commits into from

Conversation

nfrenette
Copy link
Contributor

Removed the overlay from the Archive notice, and the width now matches the width of header.

Instead of fixing the overlay and moving code around, we decided to remove the overlay entirely, so that we didn't have to fix the following 3 issues:

  1. overlay must not cause a horizontal scroll bar
  2. close button must be visible on all screen sizes
  3. user must be able to use Tab key to close overlay

Issue 1: At around 800 pixel width, the overlay “x” button to close is not visible on certain devices.

Screenshot of missing close button
image

Screenshot of visible close button on smaller device/width
image

Screenshot of visible close button on larger device/width
image

Issue 2: Horizontal scroll bar around the same screen size where the close button disappears.
image

Notice without overlay, and width matching width of header.
@duboisp
Copy link
Member

duboisp commented Nov 8, 2023

Todo for wet-boew maintainer:

  • Move the include file in the site component folder
  • Create a new documentation page for this site component
  • Need to document the current version
  • Document this change as a minor change where we technically support 2 different pattern.

(ref num: bsd-27705)

Removed inview related classes and attribute.
@Garneauma
Copy link
Contributor

@nfrenette I have opened a new PR that fixes the scrollbar issues and hidden close button (#2289). The only issue left from your list is the keyboard accessible button. I intend to fix that in another PR in WET-BOEW.

Here is a link to a demo of this fix: https://servicecanada.github.io/wet-boew-demos/gcweb-pr2289/sites/archived/archived-en.html

Please let me know if this would be a suitable fix for your issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants