Theme: Fix broken links #2179
Draft
Theme: Fix broken links #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
147a3ba
to
a66cc04
Compare
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
a66cc04
to
cd8023d
Compare
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
cd8023d
to
946459a
Compare
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
946459a
to
cc96cf9
Compare
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
cc96cf9
to
8cf66a6
Compare
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
8cf66a6
to
e397bd8
Compare
EricDunsworth
added a commit
to EricDunsworth/GCWeb
that referenced
this pull request
Jul 10, 2023
* Use the ``relative_url`` Liquid filter for the provisional page's link destination (makes it relative to ``baseurl``) * Remove the ``provisionaldir`` and ``siteroot`` variables * Fixes broken links caused by incorrect relative paths * Spinoff of wet-boew#2179
EricDunsworth
added a commit
to EricDunsworth/GCWeb
that referenced
this pull request
Jul 10, 2023
* Use the relative_url Liquid filter for the provisional page's link destination (makes it relative to ``baseurl``) * Remove the provisionaldir and siteroot variables * Fixes broken links caused by incorrect relative paths * Spinoff of wet-boew#2179
EricDunsworth
added a commit
to EricDunsworth/GCWeb
that referenced
this pull request
Jul 10, 2023
* Use the relative_url Liquid filter for the provisional page's link destination (makes it relative to baseurl) * Remove the provisionaldir and siteroot variables * Fixes broken links caused by incorrect relative paths * Spinoff of wet-boew#2179
EricDunsworth
added a commit
to EricDunsworth/GCWeb
that referenced
this pull request
Jul 10, 2023
* Use the relative_url Liquid filter for the provisional page's link destination (makes it relative to baseurl) * Remove the provisionaldir and siteroot variables * Fixes broken links caused by incorrect relative paths * Spinoff of wet-boew#2179
EricDunsworth
added a commit
to EricDunsworth/GCWeb
that referenced
this pull request
Jul 11, 2023
* Home page breadcrumb links:
* Write them as follows:
* English: "GCWeb home" (some were previously written as "GCWeb")
* Français: "GCWeb accueil" (some were previously written as "GCWeb", "GCWeb home", "Accueil GCWeb" or "Accueil de GCWeb")
* Update link destinations:
* Fix links that went to the wrong language
* Make links relative to site.baseurl (i.e. don't hardcode https://wet-boew.github.io/GCWeb/index-*.html, https://wet-boew.github.io/GCWeb/home.html, https://wet-boew.github.io/GCWeb/accueil.html or https://wet-boew.github.io/themes-dist/GCWeb/index-*.html)
* Remove the following breadcrumb links:
* Authentication pages: Outdated/unused "Canada.ca" links
* Breadcrumb trail page: Méli-mélo link (in the page itself - left its code samples intact)
* Page feedback pages: Redundant "Canada.ca" link
* Page details pages: Redundant "Canada.ca" link
* Rename the following French breadcrumb links:
* GC tables page: "Provisional functionality" to "Fonctionalités provisoires"
* Version history page: "GCWeb thème" to "Thème de GCWeb"
* Footer pages: "Footer" to "Pied de page"
* Institution landing page: "Departments & agencies" to "Ministères et organismes"
* Other breadcrumb link fixes:
* Institution landing page (French): Fix "Ministères et organismes" link destination
* Pagination for search template page (English): Fix "Search template" link destination
* GC tables pages: Fix provisional functionality link destinations
* Home page meta information page: Unveil custom breadcrumbs and fix home link destinations
* Spinoff of wet-boew#2179
EricDunsworth
added a commit
to EricDunsworth/GCWeb
that referenced
this pull request
Jul 12, 2023
* Remove the following hardcoded markup:
* wb-init and wb-*-inited classes
* wb-auto-* IDs
* Note: Fixes broken local links caused by duplicate IDs
* Update modified dates of:
* Pages containing affected code samples
* Pages that reference updated samples/includes
* Spinoff of wet-boew#2179
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
e397bd8
to
7041b96
Compare
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
7041b96
to
48aee94
Compare
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
48aee94
to
ee72fb2
Compare
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
ee72fb2
to
7c47522
Compare
EricDunsworth
added a commit
to EricDunsworth/GCWeb
that referenced
this pull request
Jul 12, 2023
* Home page breadcrumb links:
* Write them as follows:
* English: "GCWeb home" (some were previously written as "GCWeb")
* Français: "GCWeb accueil" (many were previously written as "GCWeb", "GCWeb home", "Accueil GCWeb" or "Accueil de GCWeb")
* Update link destinations:
* Fix links that went to the wrong language
* Make links relative to site.baseurl (i.e. don't hardcode https://wet-boew.github.io/GCWeb/index-*.html, https://wet-boew.github.io/GCWeb/home.html, https://wet-boew.github.io/GCWeb/accueil.html or https://wet-boew.github.io/themes-dist/GCWeb/index-*.html)
* Remove the following breadcrumb links:
* Authentication pages: Outdated/unused "Canada.ca" links
* Breadcrumb trail page: Méli-mélo link (in the page itself - left its code samples intact)
* Page details pages: Redundant "Canada.ca" link
* Page feedback pages: Redundant "Canada.ca" link
* Rename the following French breadcrumb links:
* GC tables page: "Provisional functionality" to "Fonctionalités provisoires"
* Footer pages: "Footer" to "Pied de page"
* Institution landing page: "Departments & agencies" to "Ministères et organismes"
* Version history page: "GCWeb thème" to "Thème de GCWeb"
* Other breadcrumb link fixes:
* GC tables pages: Fix provisional functionality link destinations
* Home page meta information page: Unveil custom breadcrumbs and fix home link destinations
* Institution landing page (French): Fix "Ministères et organismes" link destination
* Pagination for search template page (English): Fix "Search template" link text/destination
* Spinoff of wet-boew#2179
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
7c47522
to
ef7e32e
Compare
EricDunsworth
force-pushed
the
theme-broken-links
branch
from
ef7e32e
to
b0fdd78
Compare
duboisp
pushed a commit
to duboisp/GCWeb
that referenced
this pull request
Aug 22, 2023
* Use the relative_url Liquid filter for the provisional page's link destination (makes it relative to baseurl) * Remove the provisionaldir and siteroot variables * Fixes broken links caused by incorrect relative paths * Spinoff of wet-boew#2179
EricDunsworth
added a commit
to EricDunsworth/GCWeb
that referenced
this pull request
Sep 1, 2023
* Remove the following hardcoded markup:
* wb-init and wb-*-inited classes
* wb-auto-* IDs
* Note: Fixes broken local links caused by duplicate IDs
* Update modified dates of:
* Pages containing affected code samples
* Pages that reference updated samples/includes
* Spinoff of wet-boew#2179
duboisp
added a commit
that referenced
this pull request
Sep 11, 2023
…nance and fixing/adjusting examples (#2196) * Theme: Remove hardcoded post-JS HTML markup * Remove the following hardcoded markup: * wb-init and wb-*-inited classes * wb-auto-* IDs * Note: Fixes broken local links caused by duplicate IDs * Update modified dates of: * Pages containing affected code samples * Pages that reference updated samples/includes * Spinoff of #2179 * Content - Ajust template with the follow-us include and added example of secondary-menu * Theme: Update page modified dates with post-JS changes * Bump initial commit's page modified dates to current date * Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit GCWeb - Content - Remove hardcoded post-JS HTML markup, GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template, GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example) GCWeb Jekyll - Minor - Add basic support for content with a secondary menu --------- Co-authored-by: Pierre Dubois <[email protected]>
SebastianBurke
added a commit
to SebastianBurke/GCWeb
that referenced
this pull request
Nov 7, 2023
WET-380 Ajax Fetch Working Example Content - Follow us, Lowest topic section, HTML cleanup - Code maintenance and fixing/adjusting examples (wet-boew#2196) * Theme: Remove hardcoded post-JS HTML markup * Remove the following hardcoded markup: * wb-init and wb-*-inited classes * wb-auto-* IDs * Note: Fixes broken local links caused by duplicate IDs * Update modified dates of: * Pages containing affected code samples * Pages that reference updated samples/includes * Spinoff of wet-boew#2179 * Content - Ajust template with the follow-us include and added example of secondary-menu * Theme: Update page modified dates with post-JS changes * Bump initial commit's page modified dates to current date * Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit GCWeb - Content - Remove hardcoded post-JS HTML markup, GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template, GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example) GCWeb Jekyll - Minor - Add basic support for content with a secondary menu --------- Co-authored-by: Pierre Dubois <[email protected]> Step by step navigation: adding documentation méli-mélo 2023-09-menu - Initial commit (wet-boew#2247) Co-authored-by: gjb-pch <[email protected]> Page feedback: hiding page feedback by default and updating doc> > Co-authored-by: Pierre Dubois <[email protected]> Release v13.8.0 GC Tables: Improve display for empty cells Méli-mélo - Initial commit for: 2023-09-distance-calculator and 2023-09-collection-sort (wet-boew#2245) Initial commit of new méli-mélo project * 2023-09-distance-calculator: Initial commit * 2023-09-collection-sort: Initial commit Release v13.9.0 docs: Update guidance links in feedback docs WET-347 Fonts: fixing font loading Update campaign-menu.js Update to set focus on menu item Feedback: updating doc to add migration from RAP to PFT Release v13.9.1 Content - Review of a few components metadata (wet-boew#2261) Reviewed the component title and description for: * gc-subway * header-rwd Content - Review of a few components metadata Content - Feedback - Update documentation (wet-boew#2262) * Content - Feedback - Update documentation * Apply updates to implementation as discussed with DTO during office hours * Improved the code sample displayed in the working example * Fix the grunt script to not rely on a generated file when initiating any task * Updated the generated content * Content - Feedback - Apply suggestions from code review Co-authored-by: Garneauma <[email protected]> * Content - Feedback - Update ajax URL in code sample --------- Co-authored-by: Garneauma <[email protected]> WET-410 Created a wet-boew section in GCWeb github Changes to pre-assesments for components: language wb-tabs gc-topic gcweb-menu
SebastianBurke
added a commit
to SebastianBurke/GCWeb
that referenced
this pull request
Nov 7, 2023
# This is the 1st commit message: Accessibility Project - Pre-assessments # This is the commit message wet-boew#2: WET-380 Ajax Fetch Working Example # This is the commit message wet-boew#3: Content - Follow us, Lowest topic section, HTML cleanup - Code maintenance and fixing/adjusting examples (wet-boew#2196) * Theme: Remove hardcoded post-JS HTML markup * Remove the following hardcoded markup: * wb-init and wb-*-inited classes * wb-auto-* IDs * Note: Fixes broken local links caused by duplicate IDs * Update modified dates of: * Pages containing affected code samples * Pages that reference updated samples/includes * Spinoff of wet-boew#2179 * Content - Ajust template with the follow-us include and added example of secondary-menu * Theme: Update page modified dates with post-JS changes * Bump initial commit's page modified dates to current date * Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit GCWeb - Content - Remove hardcoded post-JS HTML markup, GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template, GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example) GCWeb Jekyll - Minor - Add basic support for content with a secondary menu --------- Co-authored-by: Pierre Dubois <[email protected]> # This is the commit message wet-boew#4: Step by step navigation: adding documentation # This is the commit message wet-boew#5: méli-mélo 2023-09-menu - Initial commit (wet-boew#2247) Co-authored-by: gjb-pch <[email protected]> # This is the commit message wet-boew#6: Page feedback: hiding page feedback by default and updating doc> > Co-authored-by: Pierre Dubois <[email protected]> # This is the commit message wet-boew#7: Release v13.8.0 # This is the commit message wet-boew#8: GC Tables: Improve display for empty cells # This is the commit message wet-boew#9: Méli-mélo - Initial commit for: 2023-09-distance-calculator and 2023-09-collection-sort (wet-boew#2245) Initial commit of new méli-mélo project * 2023-09-distance-calculator: Initial commit * 2023-09-collection-sort: Initial commit # This is the commit message wet-boew#10: Release v13.9.0 # This is the commit message wet-boew#11: docs: Update guidance links in feedback docs # This is the commit message wet-boew#12: WET-347 # This is the commit message wet-boew#13: Fonts: fixing font loading # This is the commit message wet-boew#14: Update campaign-menu.js Update to set focus on menu item # This is the commit message wet-boew#15: Feedback: updating doc to add migration from RAP to PFT # This is the commit message wet-boew#16: Release v13.9.1 # This is the commit message wet-boew#17: Content - Review of a few components metadata (wet-boew#2261) Reviewed the component title and description for: * gc-subway * header-rwd Content - Review of a few components metadata # This is the commit message wet-boew#18: Content - Feedback - Update documentation (wet-boew#2262) * Content - Feedback - Update documentation * Apply updates to implementation as discussed with DTO during office hours * Improved the code sample displayed in the working example * Fix the grunt script to not rely on a generated file when initiating any task * Updated the generated content * Content - Feedback - Apply suggestions from code review Co-authored-by: Garneauma <[email protected]> * Content - Feedback - Update ajax URL in code sample --------- Co-authored-by: Garneauma <[email protected]> # This is the commit message wet-boew#19: WET-410 Created a wet-boew section in GCWeb github
SebastianBurke
added a commit
to SebastianBurke/GCWeb
that referenced
this pull request
Nov 7, 2023
# This is the 1st commit message: Accessibility Project - Pre-assessments # This is the commit message wet-boew#2: WET-380 Ajax Fetch Working Example # This is the commit message wet-boew#3: Content - Follow us, Lowest topic section, HTML cleanup - Code maintenance and fixing/adjusting examples (wet-boew#2196) * Theme: Remove hardcoded post-JS HTML markup * Remove the following hardcoded markup: * wb-init and wb-*-inited classes * wb-auto-* IDs * Note: Fixes broken local links caused by duplicate IDs * Update modified dates of: * Pages containing affected code samples * Pages that reference updated samples/includes * Spinoff of wet-boew#2179 * Content - Ajust template with the follow-us include and added example of secondary-menu * Theme: Update page modified dates with post-JS changes * Bump initial commit's page modified dates to current date * Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit GCWeb - Content - Remove hardcoded post-JS HTML markup, GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template, GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example) GCWeb Jekyll - Minor - Add basic support for content with a secondary menu --------- Co-authored-by: Pierre Dubois <[email protected]> # This is the commit message wet-boew#4: Step by step navigation: adding documentation # This is the commit message wet-boew#5: méli-mélo 2023-09-menu - Initial commit (wet-boew#2247) Co-authored-by: gjb-pch <[email protected]> # This is the commit message wet-boew#6: Page feedback: hiding page feedback by default and updating doc> > Co-authored-by: Pierre Dubois <[email protected]>
SebastianBurke
pushed a commit
to SebastianBurke/GCWeb
that referenced
this pull request
Mar 6, 2024
* Use the relative_url Liquid filter for the provisional page's link destination (makes it relative to baseurl) * Remove the provisionaldir and siteroot variables * Fixes broken links caused by incorrect relative paths * Spinoff of wet-boew#2179
SebastianBurke
pushed a commit
to SebastianBurke/GCWeb
that referenced
this pull request
Mar 6, 2024
…nance and fixing/adjusting examples (wet-boew#2196) * Theme: Remove hardcoded post-JS HTML markup * Remove the following hardcoded markup: * wb-init and wb-*-inited classes * wb-auto-* IDs * Note: Fixes broken local links caused by duplicate IDs * Update modified dates of: * Pages containing affected code samples * Pages that reference updated samples/includes * Spinoff of wet-boew#2179 * Content - Ajust template with the follow-us include and added example of secondary-menu * Theme: Update page modified dates with post-JS changes * Bump initial commit's page modified dates to current date * Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit GCWeb - Content - Remove hardcoded post-JS HTML markup, GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template, GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example) GCWeb Jekyll - Minor - Add basic support for content with a secondary menu --------- Co-authored-by: Pierre Dubois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP