Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme: Remove hardcoded post-JS HTML markup #2196

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Theme: Remove hardcoded post-JS HTML markup #2196

merged 3 commits into from
Sep 11, 2023

Conversation

EricDunsworth
Copy link
Member

@EricDunsworth EricDunsworth commented Jul 12, 2023 •
edited
Loading

  • Remove the following hardcoded markup:
    • wb-init and wb-*-inited classes
    • wb-auto-* IDs
      • Note: Fixes broken local links caused by duplicate IDs
  • Update modified dates of:
    • Pages containing affected code samples
    • Pages that reference updated samples/includes
  • Related changes by @duboisp:
    • Revert several pages to the old incarnation of the follow-us include
    • Resurrect secondary menu examples/includes
  • Spinoff of Theme: Fix broken links #2179

@EricDunsworth EricDunsworth temporarily deployed to github-ci July 12, 2023 14:51 — with GitHub Actions Inactive
GormFrank
GormFrank previously approved these changes Jul 31, 2023
View reviewed changes
components/gc-follow-us/samples/follow.html Outdated Show resolved Hide resolved
@GormFrank
Copy link
Collaborator

Approved upon successful testing

@GormFrank GormFrank requested a review from Ricokola July 31, 2023 19:21
duboisp
duboisp previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knowing that you have found we updated by mistake the gc-followus pattern on page which shouldn't. I suggest to get that fixed before we forget about it. If I do have time today, I will add a new commit fixing this.

@duboisp
Copy link
Member

duboisp commented Aug 30, 2023 •
edited
Loading

I am going to match the follow us pattern along with the current DTO documentation based on the wireframe which is currently published as today

By default all should use the old follow us include "gc-follow-us/follow.html"

Will use the new follow us "gc-follow-us/gc-follow-us.html"

  • beta institution page
  • beta theme/topic
  • Intistitution contact page (I didn't found a wireframe showing the old follow us, so let keep it as is)

The template "localnav" look more as a variant of the topic page or a subsite section. Suggest to move it or rename it

@duboisp duboisp dismissed stale reviews from GormFrank and themself via 79bd7c1 August 30, 2023 18:18
@duboisp
Copy link
Member

duboisp commented Aug 30, 2023

@EricDunsworth I fixed the follow-us include and added working example of secondary menu (by marking it deprecated)

Can you fix the merge conflicts? Feel free to replay or includes any changes that I made via the new commit.

@GormFrank GormFrank requested review from polmih and removed request for Ricokola August 30, 2023 20:11
@polmih
Copy link
Contributor

polmih commented Aug 31, 2023

@EricDunsworth , wondering if the conflict with the master can be fixed? Thanks

@EricDunsworth
Copy link
Member Author

@polmih I'll try to rebase and make any necessary adjustments to this PR at some point today 💯.

EricDunsworth and others added 3 commits September 1, 2023 15:35
@EricDunsworth
Theme: Remove hardcoded post-JS HTML markup
768ec28 
* Remove the following hardcoded markup:
  * wb-init and wb-*-inited classes
  * wb-auto-* IDs
    * Note: Fixes broken local links caused by duplicate IDs
* Update modified dates of:
  * Pages containing affected code samples
  * Pages that reference updated samples/includes
* Spinoff of wet-boew#2179
@duboisp @EricDunsworth
Content - Ajust template with the follow-us include and added example…
93cf76d 
… of secondary-menu
@EricDunsworth
Theme: Update page modified dates with post-JS changes
5c241e0 
* Bump initial commit's page modified dates to current date
* Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit
@EricDunsworth EricDunsworth temporarily deployed to github-ci September 1, 2023 20:07 — with GitHub Actions Inactive
@EricDunsworth
Copy link
Member Author

EricDunsworth commented Sep 1, 2023 •
edited
Loading

@polmih @duboisp I think this is ready to rock and roll now :).

Just did the following:

  • Rebased/fixed merge conflicts
  • Added a third commit to update modified dates
    • Side note: I decided against editing my initial commit for that... @duboisp's second commit expanded the scope of pages needing updated modified dates. So I felt like it'd of been inappropriate to retroactively add updated modified dates for those "extra" pages in the first commit.
  • Updated the OP to cover changes from @duboisp's commit
  • Kept the OP's title "as-is" since I can't think of a way of summarizing all of my and @duboisp's updates without making it insanely long 😛

@duboisp
Copy link
Member

duboisp commented Sep 5, 2023

@polmih ready for your review. Once reviewed and tested, this has been pre-approved during the technical review.

polmih
polmih approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@polmih polmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and locally tested.

templates/institutional/institution-arms-en.html Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Sep 11, 2023

Thanks @polmih

Change type:
GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template,
GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example)
GCWeb Jekyll - Minor - Add basic support for content with a secondary menu

@duboisp duboisp merged commit 4c0c6f5 into wet-boew:master Sep 11, 2023
1 check passed
SebastianBurke added a commit to SebastianBurke/GCWeb that referenced this pull request Nov 7, 2023
@SebastianBurke
Accessibility Project - Pre-assessments
7efcc0f 
WET-380 Ajax Fetch Working Example

Content - Follow us, Lowest topic section, HTML cleanup - Code maintenance and fixing/adjusting examples (wet-boew#2196)

* Theme: Remove hardcoded post-JS HTML markup
* Remove the following hardcoded markup:
  * wb-init and wb-*-inited classes
  * wb-auto-* IDs
    * Note: Fixes broken local links caused by duplicate IDs
* Update modified dates of:
  * Pages containing affected code samples
  * Pages that reference updated samples/includes
* Spinoff of wet-boew#2179
* Content - Ajust template with the follow-us include and added example of secondary-menu
* Theme: Update page modified dates with post-JS changes
* Bump initial commit's page modified dates to current date
* Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit

GCWeb - Content - Remove hardcoded post-JS HTML markup,
GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template,
GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example)
GCWeb Jekyll - Minor - Add basic support for content with a secondary menu

---------

Co-authored-by: Pierre Dubois <[email protected]>

Step by step navigation: adding documentation

méli-mélo 2023-09-menu - Initial commit (wet-boew#2247)

Co-authored-by: gjb-pch <[email protected]>

Page feedback: hiding page feedback by default and updating doc>
>

Co-authored-by: Pierre Dubois <[email protected]>

Release v13.8.0

GC Tables: Improve display for empty cells

Méli-mélo - Initial commit for: 2023-09-distance-calculator and 2023-09-collection-sort (wet-boew#2245)

Initial commit of new méli-mélo project

* 2023-09-distance-calculator: Initial commit
* 2023-09-collection-sort: Initial commit

Release v13.9.0

docs: Update guidance links in feedback docs

WET-347

Fonts: fixing font loading

Update campaign-menu.js

Update to set focus on menu item

Feedback: updating doc to add migration from RAP to PFT

Release v13.9.1

Content - Review of a few components metadata (wet-boew#2261)

Reviewed the component title and description for:
* gc-subway
* header-rwd

Content - Review of a few components metadata

Content - Feedback - Update documentation (wet-boew#2262)

* Content - Feedback - Update documentation

* Apply updates to implementation as discussed with DTO during office hours
* Improved the code sample displayed in the working example
* Fix the grunt script to not rely on a generated file when initiating any task
* Updated the generated content

* Content - Feedback - Apply suggestions from code review

Co-authored-by: Garneauma <[email protected]>

* Content - Feedback - Update ajax URL in code sample

---------

Co-authored-by: Garneauma <[email protected]>

WET-410 Created a wet-boew section in GCWeb github

Changes to pre-assesments for components:
language
wb-tabs
gc-topic
gcweb-menu
SebastianBurke added a commit to SebastianBurke/GCWeb that referenced this pull request Nov 7, 2023
@SebastianBurke
# This is a combination of 19 commits.
ce27242 
# This is the 1st commit message:

Accessibility Project - Pre-assessments

# This is the commit message wet-boew#2:

WET-380 Ajax Fetch Working Example

# This is the commit message wet-boew#3:

Content - Follow us, Lowest topic section, HTML cleanup - Code maintenance and fixing/adjusting examples (wet-boew#2196)

* Theme: Remove hardcoded post-JS HTML markup
* Remove the following hardcoded markup:
  * wb-init and wb-*-inited classes
  * wb-auto-* IDs
    * Note: Fixes broken local links caused by duplicate IDs
* Update modified dates of:
  * Pages containing affected code samples
  * Pages that reference updated samples/includes
* Spinoff of wet-boew#2179
* Content - Ajust template with the follow-us include and added example of secondary-menu
* Theme: Update page modified dates with post-JS changes
* Bump initial commit's page modified dates to current date
* Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit


GCWeb - Content - Remove hardcoded post-JS HTML markup,
GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template,
GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example)
GCWeb Jekyll - Minor - Add basic support for content with a secondary menu

---------

Co-authored-by: Pierre Dubois <[email protected]>
# This is the commit message wet-boew#4:

Step by step navigation: adding documentation

# This is the commit message wet-boew#5:

méli-mélo 2023-09-menu - Initial commit (wet-boew#2247)

Co-authored-by: gjb-pch <[email protected]>
# This is the commit message wet-boew#6:

Page feedback: hiding page feedback by default and updating doc>
>

Co-authored-by: Pierre Dubois <[email protected]>

# This is the commit message wet-boew#7:

Release v13.8.0

# This is the commit message wet-boew#8:

GC Tables: Improve display for empty cells

# This is the commit message wet-boew#9:

Méli-mélo - Initial commit for: 2023-09-distance-calculator and 2023-09-collection-sort (wet-boew#2245)

Initial commit of new méli-mélo project

* 2023-09-distance-calculator: Initial commit
* 2023-09-collection-sort: Initial commit
# This is the commit message wet-boew#10:

Release v13.9.0

# This is the commit message wet-boew#11:

docs: Update guidance links in feedback docs

# This is the commit message wet-boew#12:

WET-347

# This is the commit message wet-boew#13:

Fonts: fixing font loading

# This is the commit message wet-boew#14:

Update campaign-menu.js

Update to set focus on menu item
# This is the commit message wet-boew#15:

Feedback: updating doc to add migration from RAP to PFT

# This is the commit message wet-boew#16:

Release v13.9.1

# This is the commit message wet-boew#17:

Content - Review of a few components metadata (wet-boew#2261)

Reviewed the component title and description for:
* gc-subway
* header-rwd

Content - Review of a few components metadata
# This is the commit message wet-boew#18:

Content - Feedback - Update documentation (wet-boew#2262)

* Content - Feedback - Update documentation

* Apply updates to implementation as discussed with DTO during office hours
* Improved the code sample displayed in the working example
* Fix the grunt script to not rely on a generated file when initiating any task
* Updated the generated content

* Content - Feedback - Apply suggestions from code review

Co-authored-by: Garneauma <[email protected]>

* Content - Feedback - Update ajax URL in code sample

---------

Co-authored-by: Garneauma <[email protected]>
# This is the commit message wet-boew#19:

WET-410 Created a wet-boew section in GCWeb github
SebastianBurke added a commit to SebastianBurke/GCWeb that referenced this pull request Nov 7, 2023
@SebastianBurke
# This is a combination of 6 commits.
95b32e5 
# This is the 1st commit message:

Accessibility Project - Pre-assessments

# This is the commit message wet-boew#2:

WET-380 Ajax Fetch Working Example

# This is the commit message wet-boew#3:

Content - Follow us, Lowest topic section, HTML cleanup - Code maintenance and fixing/adjusting examples (wet-boew#2196)

* Theme: Remove hardcoded post-JS HTML markup
* Remove the following hardcoded markup:
  * wb-init and wb-*-inited classes
  * wb-auto-* IDs
    * Note: Fixes broken local links caused by duplicate IDs
* Update modified dates of:
  * Pages containing affected code samples
  * Pages that reference updated samples/includes
* Spinoff of wet-boew#2179
* Content - Ajust template with the follow-us include and added example of secondary-menu
* Theme: Update page modified dates with post-JS changes
* Bump initial commit's page modified dates to current date
* Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit


GCWeb - Content - Remove hardcoded post-JS HTML markup,
GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template,
GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example)
GCWeb Jekyll - Minor - Add basic support for content with a secondary menu

---------

Co-authored-by: Pierre Dubois <[email protected]>
# This is the commit message wet-boew#4:

Step by step navigation: adding documentation

# This is the commit message wet-boew#5:

méli-mélo 2023-09-menu - Initial commit (wet-boew#2247)

Co-authored-by: gjb-pch <[email protected]>
# This is the commit message wet-boew#6:

Page feedback: hiding page feedback by default and updating doc>
>

Co-authored-by: Pierre Dubois <[email protected]>
SebastianBurke pushed a commit to SebastianBurke/GCWeb that referenced this pull request Mar 6, 2024
@EricDunsworth @duboisp @SebastianBurke
Content - Follow us, Lowest topic section, HTML cleanup - Code mainte…
5de2815 
…nance and fixing/adjusting examples (wet-boew#2196)

* Theme: Remove hardcoded post-JS HTML markup
* Remove the following hardcoded markup:
  * wb-init and wb-*-inited classes
  * wb-auto-* IDs
    * Note: Fixes broken local links caused by duplicate IDs
* Update modified dates of:
  * Pages containing affected code samples
  * Pages that reference updated samples/includes
* Spinoff of wet-boew#2179
* Content - Ajust template with the follow-us include and added example of secondary-menu
* Theme: Update page modified dates with post-JS changes
* Bump initial commit's page modified dates to current date
* Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit


GCWeb - Content - Remove hardcoded post-JS HTML markup,
GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template,
GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example)
GCWeb Jekyll - Minor - Add basic support for content with a secondary menu

---------

Co-authored-by: Pierre Dubois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duboisp duboisp duboisp left review comments

@polmih polmih polmih approved these changes

@GormFrank GormFrank GormFrank left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EricDunsworth @GormFrank @duboisp @polmih