-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WCAG upgrage - add an test & example file for download-link #2152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todo:
- Move the download link component in the "component" folder
- Create an EN and FR documentation page which will at least show:
- Status
- Current component version number (here is version 1.0.0)
- Type of component: which could be defined as "Content area component"
- A link to the Canada.ca design system website about this pattern
- A placeholder section for "Evaluation and report"
- A section about "Variants" where it only said there is 1 variant.
- Remove the EN and FR working example from this page:
- Move the style into a new "_base.scss" file in the download link component
GCWeb/components/baseline/_base.scss
Line 6 in 4c3c5cf
.gc-dwnld {
- Optional - You can complement the download link documentation by adding your observation according to each applicable and essential dimension for this component as defined by our public versioning API draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @shiva-sc
I completed the full review and we will most likely be able to merge this PR once you completed those little change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
This is a content change with a patch change to our style.
We will be able to merge this PR at our next technical review meeting.
No description provided.