Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG upgrage - add an test & example file for download-link #2152

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

shiva-sc
Copy link
Contributor

No description provided.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

common/download-link/download_link-en.html Outdated Show resolved Hide resolved
common/download-link/index.json-ld Outdated Show resolved Hide resolved
common/download-link/index.json-ld Outdated Show resolved Hide resolved
@shiva-sc shiva-sc temporarily deployed to github-ci June 15, 2023 17:45 — with GitHub Actions Inactive
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @shiva-sc

I completed the full review and we will most likely be able to merge this PR once you completed those little change.

components/gc-dwnld/download_link-en.html Outdated Show resolved Hide resolved
components/gc-dwnld/download_link-fr.html Outdated Show resolved Hide resolved
components/gc-dwnld/download_link-fr.html Outdated Show resolved Hide resolved
components/gc-dwnld/index.json-ld Outdated Show resolved Hide resolved
@shiva-sc shiva-sc temporarily deployed to github-ci July 14, 2023 15:58 — with GitHub Actions Inactive
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

This is a content change with a patch change to our style.

We will be able to merge this PR at our next technical review meeting.

@duboisp duboisp merged commit 972497a into wet-boew:master Aug 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants