Skip to content

Commit

Permalink
Patch - Merge pull request #2152 from shiva-sc/dwnld-link
Browse files Browse the repository at this point in the history
WCAG upgrage - add an test & example file for download-link

Patch - Download link - Technical change, isolated the CSS for the download link
  • Loading branch information
duboisp authored Aug 21, 2023
2 parents 59416d0 + b645763 commit 972497a
Show file tree
Hide file tree
Showing 8 changed files with 164 additions and 71 deletions.
24 changes: 0 additions & 24 deletions components/baseline/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,6 @@
* Components styles
*/

// Download link box
.gc-dwnld {

.gc-dwnld-txt {
text-decoration: underline;

&:hover {
text-decoration: none;
}

span {
display: block;
}
}

.gc-dwnld-img {
margin-bottom: 0;
}

p {
margin-bottom:0;
}
}

// Step by step navigation used on Advanced service template
.gc-stp-stp {
border-bottom: solid 1px #ccc;
Expand Down
23 changes: 0 additions & 23 deletions components/components-en.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,29 +22,6 @@ <h2>Table of contents</h2>
<li><a href="#alert">Alert designs</a></li>
</ul>
</nav>
<section>
<h2 id="download">Download link</h2>
<p>Download links are used for referencing and linking to non-HTML files on Canada.ca web pages.</p>
<div class="row">
<div class="col-sm-4">
<a class="gc-dwnld-lnk" href="#">
<div class="well gc-dwnld">
<div class="row">
<div class="col-xs-4">
<p><img class="img-responsive thumbnail gc-dwnld-img" src="./../templates/img/doc.png" alt="" /></p>
</div>
<div class="col-xs-8">
<p class="gc-dwnld-txt">
<span>Document Title</span>
<span class="gc-dwnld-info">(<abbr title="Portable Document Format">PDF</abbr>, 273 <abbr title="KiloByte">KB</abbr>)</span>
</p>
</div>
</div>
</div>
</a>
</div>
</div>
</section>
<section class="gc-toc">
<h2 id="toc">In-page table of contents</h2>
<p>The In-Page Table of Contents Pattern is a list of links that lead to subsections of the same page. This pattern is intended for long documents that exist as a single page.</p>
Expand Down
24 changes: 0 additions & 24 deletions components/components-fr.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,35 +15,11 @@
<nav role="navigation" class="gc-toc">
<h2>Table des matières</h2>
<ul>
<li><a href="#telechargement">Lien de téléchargement</a></li>
<li><a href="#toc">Table des matières à l’intérieur de la page</a></li>
<li><a href="#min-port">Ministres du portefeuille</a></li>
<li><a href="#avis">Conceptions des avis</a></li>
</ul>
</nav>
<section>
<h2 id="telechargement">Lien de téléchargement</h2>
<p>Les liens de téléchargement servent à renvoyer ou à lier à des fichiers de format autre que HTML sur les pages Web de Canada.ca.</p>
<div class="row">
<div class="col-sm-4">
<a class="gc-dwnld-lnk" href="#">
<div class="well gc-dwnld">
<div class="row">
<div class="col-xs-4">
<p><img class="img-responsive thumbnail gc-dwnld-img" src="./../templates/img/doc.png" alt="" /></p>
</div>
<div class="col-xs-8">
<p class="gc-dwnld-txt">
<span>Titre du document</span>
<span class="gc-dwnld-info">(<abbr lang="en" title="Portable Document Format">PDF</abbr>, 273 <abbr title="kilo octet">Ko</abbr>)</span>
</p>
</div>
</div>
</div>
</a>
</div>
</div>
</section>
<section>
<h2 id="toc">Table des matières à l’intérieur de la page</h2>
<p>La configuration relative à la table des matières à l’intérieur de la page consiste en une liste de liens dirigeant vers des sous-sections de la même page. Cette configuration est utilisée pour les longs documents présentés sur une seule page.</p>
Expand Down
23 changes: 23 additions & 0 deletions components/gc-dwnld/_base.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Download link box
.gc-dwnld {

.gc-dwnld-txt {
text-decoration: underline;

&:hover {
text-decoration: none;
}

span {
display: block;
}
}

.gc-dwnld-img {
margin-bottom: 0;
}

p {
margin-bottom:0;
}
}
53 changes: 53 additions & 0 deletions components/gc-dwnld/download_link-en.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
---
{
"title": "Download link example",
"language": "en",
"altLangPage": "download_link-fr.html",
"breadcrumbs": [
{ "title": "GCWeb home", "link": "https://wet-boew.github.io/GCWeb/index-en.html" }
],
"dateModified": "2023-04-20"
}
---
<div class="wb-prettify all-pre"></div>

<p>Download links are used for referencing and linking to non-HTML files on Canada.ca web pages.</p>
<div class="row">
<div class="col-sm-4">
<a class="gc-dwnld-lnk" href="#">
<div class="well gc-dwnld">
<div class="row">
<div class="col-xs-4">
<p><img class="img-responsive thumbnail gc-dwnld-img" src="./../../templates/img/doc.png" alt="" /></p>
</div>
<div class="col-xs-8">
<p class="gc-dwnld-txt">
<span>Document Title</span>
<span class="gc-dwnld-info">(<abbr title="Portable Document Format">PDF</abbr>, 273 <abbr title="KiloByte">KB</abbr>)</span>
</p>
</div>
</div>
</div>
</a>
</div>
</div>
<p>Code</p>
<pre><code>&lt;div class="row"&gt;
&lt;div class="col-sm-4"&gt;
&lt;a class="gc-dwnld-lnk" href="#"&gt;
&lt;div class="well gc-dwnld"&gt;
&lt;div class="row"&gt;
&lt;div class="col-xs-4"&gt;
&lt;p&gt;&lt;img class="img-responsive thumbnail gc-dwnld-img" src="./../../templates/img/doc.png" alt="" /&gt;&lt;/p&gt;
&lt;/div&gt;
&lt;div class="col-xs-8"&gt;
&lt;p class="gc-dwnld-txt"&gt;
&lt;span&gt;Document Title&lt;/span&gt;
&lt;span class="gc-dwnld-info"&gt;(&lt;abbr title="Portable Document Format"&gt;PDF&lt;/abbr&gt;, 273 &lt;abbr title="KiloByte"&gt;KB&lt;/abbr&gt;)&lt;/span&gt;
&lt;/p&gt;
&lt;/div&gt;
&lt;/div&gt;
&lt;/div&gt;
&lt;/a&gt;
&lt;/div&gt;
&lt;/div&gt;</code></pre>
53 changes: 53 additions & 0 deletions components/gc-dwnld/download_link-fr.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
---
{
"title": "Lien de téléchargement",
"language": "fr",
"altLangPage": "download_link-en.html",
"breadcrumbs": [
{ "title": "GCWeb home", "link": "https://wet-boew.github.io/GCWeb/index-en.html" }
],
"dateModified": "2023-04-20"
}
---
<div class="wb-prettify all-pre"></div>

<p>Les liens de téléchargement servent à renvoyer ou à lier à des fichiers de format autre que HTML sur les pages Web de Canada.ca.</p>
<div class="row">
<div class="col-sm-4">
<a class="gc-dwnld-lnk" href="#">
<div class="well gc-dwnld">
<div class="row">
<div class="col-xs-4">
<p><img class="img-responsive thumbnail gc-dwnld-img" src="./../../templates/img/doc.png" alt="" /></p>
</div>
<div class="col-xs-8">
<p class="gc-dwnld-txt">
<span>Titre du document</span>
<span class="gc-dwnld-info">(<abbr lang="en" title="Portable Document Format">PDF</abbr>, 273 <abbr title="kilo octet">Ko</abbr>)</span>
</p>
</div>
</div>
</div>
</a>
</div>
</div>
<p>Code</p>
<pre><code>&lt;div class="row"&gt;
&lt;div class="col-sm-4"&gt;
&lt;a class="gc-dwnld-lnk" href="#"&gt;
&lt;div class="well gc-dwnld"&gt;
&lt;div class="row"&gt;
&lt;div class="col-xs-4"&gt;
&lt;p&gt;&lt;img class="img-responsive thumbnail gc-dwnld-img" src="./../../templates/img/doc.png" alt="" /&gt;&lt;/p&gt;
&lt;/div&gt;
&lt;div class="col-xs-8"&gt;
&lt;p class="gc-dwnld-txt"&gt;
&lt;span&gt;Titre du document&lt;/span&gt;
&lt;span class="gc-dwnld-info"&gt;(&lt;abbr lang="en" title="Portable Document Format"&gt;PDF&lt;/abbr&gt;, 273 &lt;abbr title="kilo octet"&gt;Ko&lt;/abbr&gt;)&lt;/span&gt;
&lt;/p&gt;
&lt;/div&gt;
&lt;/div&gt;
&lt;/div&gt;
&lt;/a&gt;
&lt;/div&gt;
&lt;/div&gt;</code></pre>
34 changes: 34 additions & 0 deletions components/gc-dwnld/index.json-ld
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"@context": {
"@version": 1.1,
"dct": "http://purl.org/dc/terms/",
"title": { "@id": "dct:title", "@container": "@language" },
"description": { "@id": "dct:description", "@container": "@language" },
"modified": "dct:modified"
},
"title": {
"en": "Download link",
"fr": "Lien de téléchargement"
},
"description": {
"en": "Download link with custom styles.",
"fr": "Lien de téléchargement avec des styles personalisés."
},
"modified": "2023-04-20",
"componentName": "gc-dwnld",
"status": "stable",
"pages": {
"examples": [
{
"title": "Download link",
"language": "en",
"path": "download_link-en.html"
},
{
"title": "Lien de téléchargement",
"language": "fr",
"path": "download_link-fr.html"
}
]
}
}
1 change: 1 addition & 0 deletions sites/theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@
@import "../components/base2";
@import "../components/provisional";

@import "../components/gc-dwnld/base";
@import "../components/gc-nws/base";
@import "../components/gc-servinfo/base";
@import "../components/redacted";
Expand Down

0 comments on commit 972497a

Please sign in to comment.