Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass taxon to sort helper #5

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Conversation

LucaGallinari
Copy link
Member

@LucaGallinari LucaGallinari commented Jul 4, 2024

Nullable so that it's not a breaking change

@LucaGallinari LucaGallinari requested a review from lruozzi9 July 4, 2024 12:31
src/Helper/SortHelper.php Outdated Show resolved Hide resolved
src/Helper/SortHelperInterface.php Outdated Show resolved Hide resolved
@LucaGallinari LucaGallinari force-pushed the pass-taxon-to-sort-helper branch from 70e2e43 to 9f24f9c Compare July 4, 2024 12:57
@LucaGallinari
Copy link
Member Author

I see that it's normal that the plugin failes on ES 8.8 due to this: elastic/elastic-github-actions#32

@LucaGallinari LucaGallinari merged commit 06be08a into main Jul 4, 2024
8 of 16 checks passed
@lruozzi9 lruozzi9 deleted the pass-taxon-to-sort-helper branch July 4, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants