Pass taxon to sort helper method as first arg

webgriffe · Jul 4, 2024 · 9f24f9c · 9f24f9c
1 parent aa1f1b2
commit 9f24f9c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Controller/ProductController.php b/src/Controller/ProductController.php
@@ -69,7 +69,7 @@ public function __invoke(Request $request, string $slug): Response
 
         /** @var array<string, string> $sorting */
         $sorting = $request->query->all('sorting');
-        $sorting = $this->sortHelper->retrieveTaxonSorting($sorting, $taxon);
+        $sorting = $this->sortHelper->retrieveTaxonSorting($taxon, $sorting);
         $size = $request->query->getInt('limit', $this->taxonDefaultPageLimit);
         $page = $request->query->getInt('page', 1);
 

diff --git a/src/Helper/SortHelper.php b/src/Helper/SortHelper.php
@@ -13,7 +13,7 @@ public function retrieveSearchSorting(array $sortingQueryParams = []): array
         return $sortingQueryParams; // If empty it will sort by _score desc as default
     }
 
-    public function retrieveTaxonSorting(array $sortingQueryParams = [], TaxonInterface $taxon): array
+    public function retrieveTaxonSorting(TaxonInterface $taxon, array $sortingQueryParams = []): array
     {
         if ($sortingQueryParams === []) {
             return ['position' => 'asc'];

diff --git a/src/Helper/SortHelperInterface.php b/src/Helper/SortHelperInterface.php
@@ -20,5 +20,5 @@ public function retrieveSearchSorting(array $sortingQueryParams = []): array;
      *
      * @return array<string, string>
      */
-    public function retrieveTaxonSorting(array $sortingQueryParams = [], TaxonInterface $taxon): array;
+    public function retrieveTaxonSorting(TaxonInterface $taxon, array $sortingQueryParams = []): array;
 }