Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/logoffed post list #30

Merged
merged 3 commits into from
Jan 17, 2021
Merged

Feature/logoffed post list #30

merged 3 commits into from
Jan 17, 2021

Conversation

hywook4
Copy link
Contributor

@hywook4 hywook4 commented Jan 10, 2021

resolves #25
resloves #26

로그오프 시, 불러올 수 있는 영상 목록

  • 최신 영상
  • 인기 영상

좋아요 전체 수 관리는 Video model에 totalLikes추가

인기 영상의 경우는 가장 인기있는 top 20개만 가져오고 추가로 가져오는 로직은 일단 X

@hywook4 hywook4 requested a review from zych1751 January 10, 2021 07:37
Copy link
Collaborator

@zych1751 zych1751 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나머지는 좋습니당 :)

Comment on lines 26 to 28
}

else{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if-else 쌍으로 묶이는거면 띄우지말고 같은 라인에 적는게 좋지 않을까요?

@hywook4 hywook4 merged commit 914cece into master Jan 17, 2021
@hywook4 hywook4 deleted the feature/logoffed-post-list branch January 18, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

로그인이 안되어있는 메인페이지 영상 가져오기
2 participants