Feature/offline main page #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zych1751
reviewed
Jan 11, 2021
src/api/home.ts
Outdated
| const getRecentVideoPosts = async (pageToken:number|null): Promise<videoPostsResponse> => { | ||
| const res = await axios.request<videoPostsResponse>({ | ||
| baseURL: API_URL, | ||
| url: '/v1/post-list/recent-videos', |
There was a problem hiding this comment.
webdonalds/YAS-backend#30 에서는 /v1/logoffed-post-list라고 되어있는데 여기선 v1/post-list 로 쓰고 있습니다.
둘중에 하나는 고쳐져야겠네요.
src/api/home.ts
Outdated
| const getHotVideoPosts = async (): Promise<videoPostsResponse> => { | ||
| const res = await axios.request<videoPostsResponse>({ | ||
| baseURL: API_URL, | ||
| url: '/v1/post-list/hot-videos', |
Comment on lines
6
to
8
| const getYoutubeThumbnailUrl = (id: string) => { | ||
| return `https://img.youtube.com/vi/${id}/0.jpg`; | ||
| } |
There was a problem hiding this comment.
다른 곳에서도 사용되는 함수같은데 util.ts 파일 같은것을 만들어서 따로 관리해도 좋지 않을까요?
There was a problem hiding this comment.
이건 말하신대로 따로 빼면 좋을 것 같습니다. 앞으로도 여러곳에서 사용될 예정입니다.
|
모두 변경 완료 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #15
로그인이 되어있지 않은 유저에 대한 메인 페이지
스크롤 시 추가 영상 불러오기 기능.