Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing artoolkitNFT as a global variable (part 2) #283

Merged
merged 12 commits into from
Feb 27, 2023
Merged

Removing artoolkitNFT as a global variable (part 2) #283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
86158e2
avoid using frameMalloc to pass data
kalwalt Feb 22, 2023
62fab44
removing dataHeap, frameMalloc and other pointers
kalwalt Feb 23, 2023
34633bf
running prettier
kalwalt Feb 23, 2023
f922f99
using new method passVideoData()
kalwalt Feb 23, 2023
0230423
fix for .api.js and _ES6.api.js libs
kalwalt Feb 24, 2023
7058fee
fix for issue passing custom grayscale data
kalwalt Feb 24, 2023
38882a1
upgrading packages
kalwalt Feb 24, 2023
c5b1ae0
removing matrixCopy() see matrixCopy is not required #284
kalwalt Feb 27, 2023
1864c08
using emsdk 3.1.32
kalwalt Feb 27, 2023
354fc70
prettifying
kalwalt Feb 27, 2023
70b67a0
upgrading typedoc
kalwalt Feb 27, 2023
6cc14f7
completely removing artoolkitNFT global variable
kalwalt Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/ARToolkitNFT.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/ARToolkitNFT_simd.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/ARControllerNFT.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ export default class ARControllerNFT implements AbstractARControllerNFT {
q += 4;
}
} else if (this.grayscaleEnabled == true) {
this.videoLuma.set(this.grayscaleSource);
Copy link
Member Author

@kalwalt kalwalt Feb 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't understand why this will make fail, with an out bounds error. I will investigate.

this.videoLuma = this.grayscaleSource;
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/ARControllerNFT_simd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ export default class ARControllerNFT implements AbstractARControllerNFT {
q += 4;
}
} else if (this.grayscaleEnabled == true) {
this.videoLuma.set(this.grayscaleSource);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as bove.

this.videoLuma = this.grayscaleSource;
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/index_simd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
*
*/
import ARToolkitNFT from "./ARToolkitNFT_simd";
import ARControllerNFT from "./ARControllerNFT";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was exporting the wrong lib here! it wasn't using simd at all...

import ARControllerNFT from "./ARControllerNFT_simd";

export default {
ARToolkitNFT,
Expand Down
2 changes: 1 addition & 1 deletion types/src/index_simd.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import ARToolkitNFT from "./ARToolkitNFT_simd";
import ARControllerNFT from "./ARControllerNFT";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above.

import ARControllerNFT from "./ARControllerNFT_simd";
declare const _default: {
ARToolkitNFT: typeof ARToolkitNFT;
ARControllerNFT: typeof ARControllerNFT;
Expand Down