Removing artoolkitNFT as a global variable (part 2) #283

kalwalt · 2023-02-23T20:13:06Z

List of Features/changes

This PR is a continuation from # 276

removed frameMalloc, dataHeap and all related code
new method passVideoData()
remove matrixCopy() see issue matrixCopy is not required #284
completely removing artoolkitNFT as a global variable

kalwalt · 2023-02-23T21:22:27Z

Node tests fails because i haven't updated the artoolkit.api.js to reflect the new changes in the ARToolKitJS.cpp code. i will fix this in another commit.
At this point the code can detect and track the pinball image, but i note a worste performance, probably because we are transferring videoFrame data and and videoLuma more times (see detectMarker, detectNFTMarker and getNFTMarkerInfo), we should instead avoid this and pass only one time the data. For this i created the passVideoData method, but i haven't yet created the typescript/js wrapper for this.

emscripten/ARToolKitJS.cpp

kalwalt · 2023-02-24T13:47:47Z

While testing the ARToolkitNFT_ES6_gray_example.html example i got:

ARToolkitNFT_simd.js:2 Uncaught RangeError: offset is out of bounds
    at Uint8Array.set (<anonymous>)
    at A.value (ARToolkitNFT_simd.js:2:1454854)
    at A.value (ARToolkitNFT_simd.js:2:1449673)
    at A.value (ARToolkitNFT_simd.js:2:1448320)
    at process (artoolkitNFT_ES6_gray.worker.js:118:8)
    at self.onmessage (artoolkitNFT_ES6_gray.worker.js:44:7)
value @ ARToolkitNFT_simd.js:2
value @ ARToolkitNFT_simd.js:2
value @ ARToolkitNFT_simd.js:2
process @ artoolkitNFT_ES6_gray.worker.js:118
self.onmessage @ artoolkitNFT_ES6_gray.worker.js:44

- see comment #283 (comment)

kalwalt · 2023-02-27T14:58:42Z

src/index_simd.ts

@@ -34,7 +34,7 @@
 *
 */
 import ARToolkitNFT from "./ARToolkitNFT_simd";
-import ARControllerNFT from "./ARControllerNFT";


i was exporting the wrong lib here! it wasn't using simd at all...

kalwalt · 2023-02-27T14:59:04Z

types/src/index_simd.d.ts

@@ -1,5 +1,5 @@
 import ARToolkitNFT from "./ARToolkitNFT_simd";
-import ARControllerNFT from "./ARControllerNFT";


same as above.

kalwalt · 2023-02-27T15:00:39Z

src/ARControllerNFT.ts

@@ -918,7 +918,7 @@ export default class ARControllerNFT implements AbstractARControllerNFT {
          q += 4;
        }
      } else if (this.grayscaleEnabled == true) {
-        this.videoLuma.set(this.grayscaleSource);


i can't understand why this will make fail, with an out bounds error. I will investigate.

kalwalt · 2023-02-27T15:01:00Z

src/ARControllerNFT_simd.ts

@@ -918,7 +918,7 @@ export default class ARControllerNFT implements AbstractARControllerNFT {
          q += 4;
        }
      } else if (this.grayscaleEnabled == true) {
-        this.videoLuma.set(this.grayscaleSource);


same as bove.

kalwalt · 2023-02-27T15:16:52Z

I think i can delete these lines of code

jsartoolkitNFT/src/ARToolkitNFT.ts

Lines 45 to 47 in e9cd198

    
           declare global { 
        
             var artoolkitNFT: IARToolkitNFT; 
        
           }

and

jsartoolkitNFT/src/ARToolkitNFT.ts

Lines 133 to 134 in e9cd198

    
           let scope = typeof window !== "undefined" ? window : global; 
        
           scope.artoolkitNFT = this;

actually you can't use the artoolkitNFT global variable because is not correctly exported (attached) to the window object.
I will leave untouched the old code (the minified and other build libs...) but i think we can avoid the use of a global variable.

- see comment #283 (comment)

avoid using frameMalloc to pass data

86158e2

kalwalt added enhancement New feature or request javascript_code C/C++ emscripten Typescript labels Feb 23, 2023

kalwalt self-assigned this Feb 23, 2023

kalwalt mentioned this pull request Feb 23, 2023

remove artoolkitNFT gloabl variable #276

Open

3 tasks

kalwalt added 2 commits February 23, 2023 22:00

removing dataHeap, frameMalloc and other pointers

62fab44

running prettier

34633bf

kalwalt commented Feb 23, 2023

View reviewed changes

emscripten/ARToolKitJS.cpp Outdated Show resolved Hide resolved

using new method passVideoData()

f922f99

kalwalt force-pushed the feature-remove-global-variable branch from 7471ad3 to f922f99 Compare February 23, 2023 22:42

kalwalt added 6 commits February 24, 2023 15:22

fix for .api.js and _ES6.api.js libs

0230423

fix for issue passing custom grayscale data

7058fee

- see comment #283 (comment)

upgrading packages

38882a1

removing matrixCopy() see matrixCopy is not required #284

c5b1ae0

using emsdk 3.1.32

1864c08

prettifying

354fc70

kalwalt commented Feb 27, 2023

View reviewed changes

upgrading typedoc

70b67a0

completely removing artoolkitNFT global variable

6cc14f7

kalwalt merged commit f3660b9 into dev Feb 27, 2023

kalwalt added a commit that referenced this pull request Feb 27, 2023

fix for issue passing custom grayscale data

11dd3df

- see comment #283 (comment)

kalwalt deleted the feature-remove-global-variable branch February 27, 2023 23:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing artoolkitNFT as a global variable (part 2) #283

Removing artoolkitNFT as a global variable (part 2) #283

kalwalt commented Feb 23, 2023 •

edited

Loading

kalwalt commented Feb 23, 2023 •

edited

Loading

kalwalt commented Feb 24, 2023

kalwalt Feb 27, 2023

kalwalt Feb 27, 2023

kalwalt Feb 27, 2023 •

edited

Loading

kalwalt Feb 27, 2023

kalwalt commented Feb 27, 2023 •

edited

Loading

		@@ -1,5 +1,5 @@
		import ARToolkitNFT from "./ARToolkitNFT_simd";
		import ARControllerNFT from "./ARControllerNFT";

Removing artoolkitNFT as a global variable (part 2) #283

Removing artoolkitNFT as a global variable (part 2) #283

Conversation

kalwalt commented Feb 23, 2023 • edited Loading

List of Features/changes

kalwalt commented Feb 23, 2023 • edited Loading

kalwalt commented Feb 24, 2023

kalwalt Feb 27, 2023

Choose a reason for hiding this comment

kalwalt Feb 27, 2023

Choose a reason for hiding this comment

kalwalt Feb 27, 2023 • edited Loading

Choose a reason for hiding this comment

kalwalt Feb 27, 2023

Choose a reason for hiding this comment

kalwalt commented Feb 27, 2023 • edited Loading

kalwalt commented Feb 23, 2023 •

edited

Loading

kalwalt commented Feb 23, 2023 •

edited

Loading

kalwalt Feb 27, 2023 •

edited

Loading

kalwalt commented Feb 27, 2023 •

edited

Loading