outcalls: auto generate name to improve multi-tenancy #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
bloom1
force-pushed
the
WAZO-3314-multi-tenant-outcall
branch
from
298f8e5 to
97549ab
Compare
|
Build failed.
|
|
Build succeeded.
|
bloom1
force-pushed
the
WAZO-3314-multi-tenant-outcall
branch
from
26fe1c3 to
045c899
Compare
|
Build succeeded.
|
|
Kudos, SonarCloud Quality Gate passed!
|
fblackburn1
requested changes
Jul 27, 2023
| @@ -40,6 +44,18 @@ class OutcallSchema(BaseSchema): | |||
| dump_only=True, | |||
| ) | |||
|
|
|||
| # DEPRECATED 23.10 | |||
There was a problem hiding this comment.
Suggested change
| # DEPRECATED 23.10 | |
| # DEPRECATED 23.11 |
| # Outcalls do not use UUIDs yet | ||
| form['name'] = self.outcall_name_fmt.format( | ||
| tenant_slug=tenant.slug, | ||
| outcall_uuid=uuid4(), |
There was a problem hiding this comment.
same comment as: #401 (comment)
About adding uuid in database
Comment on lines
-50
to
-55
| yield s.check_bogus_field_returns_error, url, 'name', True | ||
| yield s.check_bogus_field_returns_error, url, 'name', None | ||
| yield s.check_bogus_field_returns_error, url, 'name', s.random_string(129) | ||
| yield s.check_bogus_field_returns_error, url, 'name', 1234 | ||
| yield s.check_bogus_field_returns_error, url, 'name', [] | ||
| yield s.check_bogus_field_returns_error, url, 'name', {} |
There was a problem hiding this comment.
same comment as #401 (comment)
about testing deprecated name
fblackburn1
requested changes
Jul 27, 2023
| @@ -15,5 +14,4 @@ def build_validator(): | |||
| create=[ | |||
| UniqueField('name', lambda name: outcall_dao.find_by(name=name), 'Outcall') | |||
There was a problem hiding this comment.
I would remove this validator too, since the input does not come from the user anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: wazo-platform/xivo-manage-db#207
Depends-On: wazo-platform/xivo-dao#228