Skip to content

Commit

Permalink
outcalls: fix tests about label/names
Browse files Browse the repository at this point in the history
  • Loading branch information
bloom1 committed Jul 7, 2023
1 parent 97549ab commit 26fe1c3
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions integration_tests/suite/base/test_outcalls.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,6 @@ def error_checks(url):
)
yield s.check_bogus_field_returns_error, url, 'preprocess_subroutine', []
yield s.check_bogus_field_returns_error, url, 'preprocess_subroutine', {}
yield s.check_bogus_field_returns_error, url, 'name', True
yield s.check_bogus_field_returns_error, url, 'name', None
yield s.check_bogus_field_returns_error, url, 'name', s.random_string(129)
yield s.check_bogus_field_returns_error, url, 'name', 1234
yield s.check_bogus_field_returns_error, url, 'name', []
yield s.check_bogus_field_returns_error, url, 'name', {}
yield s.check_bogus_field_returns_error, url, 'name', 'name'
yield s.check_bogus_field_returns_error, url, 'label', 123
yield s.check_bogus_field_returns_error, url, 'label', None
yield s.check_bogus_field_returns_error, url, 'label', True
Expand Down Expand Up @@ -131,6 +124,7 @@ def test_get(outcall):
description=outcall['description'],
internal_caller_id=outcall['internal_caller_id'],
name=outcall['name'],
label=outcall['label'],
ring_time=outcall['ring_time'],
trunks=empty(),
),
Expand Down Expand Up @@ -158,7 +152,7 @@ def test_create_minimal_parameters():

def test_create_all_parameters():
parameters = {
'name': 'MyOutcall',
'label': 'My Outcall',
'internal_caller_id': True,
'preprocess_subroutine': 'subroutine',
'ring_time': 10,
Expand All @@ -183,7 +177,7 @@ def test_edit_minimal_parameters(outcall):
@fixtures.outcall()
def test_edit_all_parameters(outcall):
parameters = {
'name': 'MyOutcall',
'label': 'MyOutcall',
'internal_caller_id': True,
'preprocess_subroutine': 'subroutine',
'ring_time': 10,
Expand Down

0 comments on commit 26fe1c3

Please sign in to comment.