Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NPM packages & start to use Node 20 #38

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Update NPM packages & start to use Node 20 #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
32 changes: 16 additions & 16 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,14 @@ Our default export contains all of our Stylelint rules, along with specific plug
| [`scale-unlimited/declaration-strict-value`][37] | Enabled - [see Config][config] |
| [`scss/at-extend-no-missing-placeholder`][38] | Enabled |
| [`scss/at-if-no-null`][39] | Enabled |
| [`scss/at-import-no-partial-leading-underscore`][40] | Enabled |
| [`scss/at-import-partial-extension-blacklist`][41] | `"scss"` |
| [`scss/at-rule-no-unknown`][42] | Enabled |
| [`scss/comment-no-empty`][43] | Enabled |
| [`scss/declaration-nested-properties-no-divided-groups`][44] | Enabled |
| [`scss/dollar-variable-no-missing-interpolation`][45] | Enabled |
| [`scss/function-quote-no-quoted-strings-inside`][46] | Enabled |
| [`scss/function-unquote-no-unquoted-strings-inside`][47] | Enabled |
| [`scss/at-import-partial-extension-blacklist`][40] | `"scss"` |
| [`scss/at-rule-no-unknown`][41] | Enabled |
| [`scss/comment-no-empty`][42] | Enabled |
| [`scss/declaration-nested-properties-no-divided-groups`][43] | Enabled |
| [`scss/dollar-variable-no-missing-interpolation`][44] | Enabled |
| [`scss/function-quote-no-quoted-strings-inside`][45] | Enabled |
| [`scss/function-unquote-no-unquoted-strings-inside`][46] | Enabled |
| [`scss/load-no-partial-leading-underscore`][47] | Enabled |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would produce a much smaller diff if we just update scss/at-import-no-partial-leading-underscore with scss/load-no-partial-leading-underscore instead of removing the former and appending the latter to the bottom

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This listing is generated automatically. It would probably be a lot more work to make it ordered custom.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #27 for context.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't know that. That's cool, thanks!

| [`scss/media-feature-value-dollar-variable`][48] | `"always", {"ignore":["keywords"]}` |
| [`scss/no-duplicate-mixins`][49] | Enabled |
| [`scss/no-global-function-names`][50] | Enabled |
Expand Down Expand Up @@ -152,14 +152,14 @@ Our default export contains all of our Stylelint rules, along with specific plug
[37]: https://github.com/AndyOGo/stylelint-declaration-strict-value
[38]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-extend-no-missing-placeholder/README.md
[39]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-if-no-null/README.md
[40]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-import-no-partial-leading-underscore/README.md
[41]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-import-partial-extension-blacklist/README.md
[42]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-rule-no-unknown/README.md
[43]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/comment-no-empty/README.md
[44]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/declaration-nested-properties-no-divided-groups/README.md
[45]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/dollar-variable-no-missing-interpolation/README.md
[46]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/function-quote-no-quoted-strings-inside/README.md
[47]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/function-unquote-no-unquoted-strings-inside/README.md
[40]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-import-partial-extension-blacklist/README.md
[41]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-rule-no-unknown/README.md
[42]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/comment-no-empty/README.md
[43]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/declaration-nested-properties-no-divided-groups/README.md
[44]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/dollar-variable-no-missing-interpolation/README.md
[45]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/function-quote-no-quoted-strings-inside/README.md
[46]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/function-unquote-no-unquoted-strings-inside/README.md
[47]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/load-no-partial-leading-underscore/README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

[48]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/media-feature-value-dollar-variable/README.md
[49]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/no-duplicate-mixins/README.md
[50]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/no-global-function-names/README.md
Expand Down
Loading