Update NPM packages & start to use Node 20 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lb-
commented
Nov 12, 2023
lb-
commented
- Update all packages to the latest available
- Changed: replaced deprecated scss/at-import-no-partial-leading-underscore rule with scss/load-no-partial-leading-underscore rule.
- Update Node to use version 20 (including CI).
- Wagtail core is now on Node 20, so hoping to align Upgrade to Node 20 wagtail#11141
- Changed: replaced deprecated scss/at-import-no-partial-leading-underscore rule with scss/load-no-partial-leading-underscore rule. - Update Node to use version 20 (including CI) - Update all packages to the latest available
laymonage
approved these changes
Nov 13, 2023
| | [`scss/dollar-variable-no-missing-interpolation`][44] | Enabled | | ||
| | [`scss/function-quote-no-quoted-strings-inside`][45] | Enabled | | ||
| | [`scss/function-unquote-no-unquoted-strings-inside`][46] | Enabled | | ||
| | [`scss/load-no-partial-leading-underscore`][47] | Enabled | |
There was a problem hiding this comment.
I think it would produce a much smaller diff if we just update scss/at-import-no-partial-leading-underscore with scss/load-no-partial-leading-underscore instead of removing the former and appending the latter to the bottom
There was a problem hiding this comment.
This listing is generated automatically. It would probably be a lot more work to make it ordered custom.
There was a problem hiding this comment.
Oh, I didn't know that. That's cool, thanks!
| [44]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/dollar-variable-no-missing-interpolation/README.md | ||
| [45]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/function-quote-no-quoted-strings-inside/README.md | ||
| [46]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/function-unquote-no-unquoted-strings-inside/README.md | ||
| [47]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/load-no-partial-leading-underscore/README.md |
thibaudcolas
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.