Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to parse arrays #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow to parse arrays #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/puppet-lint/plugins/check_version_comparison.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def is_num_comparison?(token)
def check
tokens.each_with_index do |token, token_idx|
next unless token.type == :VARIABLE
next unless token.value =~ /(?:version|release)$/
next unless token.value =~ /(?:version|release)$|\[(?:version|release)\]|\['(?:version|release)'\]/
next unless is_num_comparison?(token.next_code_token)
notify :warning, {
:message => 'version compared as number',
Expand All @@ -19,7 +19,7 @@ def check
:token => token,
}
end
end
end

def compared_value(token)
token.next_code_token.next_code_token.value
Expand Down