Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to parse arrays #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

davidmogar
Copy link
Member

Allow to check for versions in arrays (eg. $::os['release']['major']). Using this complex regex to not allow things like $versioncontrol in which there wouldn't be a version.

Allow to check for versions in arrays (eg. $::os['release']['major']).
Using this complex regex to not allow things like $versioncontrol in
which there wouldn't be a version.
@rnelson0
Copy link
Member

@davidmogar Tests are failing on this unfortunately.

@davidmogar
Copy link
Member Author

davidmogar commented Feb 24, 2017

@rnelson0 I've checked the Travis tests again and there is no more I can do I'm afraid of. The test in 1.9.3 is failing because tins requires Ruby 2.0 or greater.

Regarding the errors in the other two builds, they are caused because a file is not present and the exception is not properly handled. I created this merge request for Puppet-lint and has been accepted. I suppose it will be present in the next version.

With that change (at least in my computer with Ruby 2.3.0) all test run without problems:

@desk ➜  puppet-lint-version_comparison-check git:(master) ✗ bundle exec rake spec  
/usr/bin/ruby2.3 -I/var/lib/gems/2.3.0/gems/rspec-core-3.5.4/lib:/var/lib/gems/2.3.0/gems/rspec-support-3.5.0/lib /var/lib/gems/2.3.0/gems/rspec-core-3.5.4/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's default settings.
rspec/json_expectations is not available
.......

Finished in 0.02586 seconds (files took 0.68118 seconds to load)
7 examples, 0 failures

@rnelson0
Copy link
Member

Neat, we can probably push out puppet-lint 2.1.2 soon-ish for you. @rodjek

@rodjek
Copy link
Member

rodjek commented Mar 30, 2017

@davidmogar puppet-lint 2.2.1 has been released with your fix

@bastelfreak
Copy link
Member

Hi @davidmogar, are you still interested in getting this merged? If so, could you please rebase and take another look at the travis issues (if they reoccur).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants