-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Quantization] Channel-wise Output Activation Quantization for Attention QKV Modules + KV-cache channel quantization #1233
Draft
horheynm
wants to merge
9
commits into
main
Choose a base branch
from
attn_quant
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tn_quant Signed-off-by: George Ohashi <[email protected]>
Signed-off-by: George Ohashi <[email protected]>
Signed-off-by: George Ohashi <[email protected]>
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Next todo is to add support for group quantization for output activations |
Signed-off-by: George Ohashi <[email protected]>
…nto attn_quant Signed-off-by: George Ohashi <[email protected]>
Signed-off-by: George Ohashi <[email protected]>
Will break down kv-cache logic to a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on : neuralmagic/compressed-tensors#270
SUMMARY:
Quantize the output activation of the attention layers for channel wise -> did not have support -> selected wrong dim to quantize.
Quantize the kv-cache for channel wise int8 -> previously only supported tensor-wise.
Attention we need to worry about is the QKV. O/Up/down is not quantized.
Math:
x is the input vector -> tokenized + embedding
weight for QKV is Linear modules
output is the forward call of QKV with x
Expected output scales and zp shapes for output activations
Expected output scales and zp shapes for kv-cache channel
k_proj, v_proj -> [head_dim]
The observer will output the vectors in the same ndim as the given output activation tensor (ie.
torch.Size([1, 1930, 1024])
, then outputstorch.Size([1, 1, 1024]))
. Squeeze it to just gettorch.Size([1024])
, so ndim of 1.TEST PLAN: