-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OneshotRefactor] Update oneshot to post_train #1136
base: main
Are you sure you want to change the base?
Conversation
…odelArguments to post_train
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
return self.run_type | ||
if StageRunType.POST_TRAIN.value in self.group: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flip the order check if the config_name has "post_train" first before "train".
model=model, | ||
tokenizer=tokenizer, | ||
dataset=DATASET_ID, | ||
recipe=recipe, | ||
max_seq_length=MAX_SEQ_LENGTH, | ||
num_calibration_samples=NUM_CALIBRATION_SAMPLES, | ||
save_compressed=SAVE_COMPRESSED, | ||
overwrite_output_dir=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only used in training args, not post-train dep args. Will raise an error if present
we should be landing the entrypoint updates, independent of changing the naming from oneshot to post_train. |
Blocked on #1109 to obtain models without training_args
SUMMARY:
oneshot
to post_trainpost_train
have its own pipeline, decoupled formmain
post_train
's input arguments only dependent onModelArguments
,DatasetArguments
, andRecipeArguments
. AnyTrainingArguments
-related input arg will raise an error. Ex.overwrite_output_dir
.oneshot
usage in the function name (run_oneshot_and_finetune
), Enum attributes (
RecipeStages), variable name (
oneshot_model) to
post_train`."tests/llmcompressor/transformers/oneshot/oneshot_configs"
)TEST PLAN:
oneshot
usinggrep
.FOLLOWUPS:
SessionMixin.apply
)