[Oneshot Refactor] Main refactor #1110
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Can you update the PR description so it clearly lays out what PRs we should be reviewing and in what order, so that it is easier to understand the changes? |
There was a problem hiding this comment.
Have we verified example testing cases? E.g
https://github.com/vllm-project/llm-compressor/blob/main/examples/quantization_2of4_sparse_w4a16/llama7b_sparse_w4a16.py
| self.tokenizer_or_processor = self.model_args.processor | ||
| self.recipe = self.recipe_args.recipe | ||
|
|
||
| def run(self, **kwargs): |
There was a problem hiding this comment.
Is run meant to take in arguments?
The docstring shows run() being called without any inputs
There was a problem hiding this comment.
kwargs is for session init / finalize kwargs
src/llmcompressor/transformers/sparsification/compressed_tensors_utils.py
Show resolved
Hide resolved
…ame_from_model (#1108) ORDER OF REVIEWS: 1. #1108 <- current PR 2. #1103 3. #1109 4. #1110 SUMMARY: * Rename `get_shared_processor_src` to `get_processor_from_model` * Appropriate signature on `initialize_processor_from_path`, where `teacher` should be optinal TEST PLAN: * Pass all existing tests * Search `get_shared_processor_src` using pygrep ```bash 3 function pygrep() { 2 local search_term="$1" 1 shift 126 local search_dirs="${*:-src examples tests}" 1 grep -rn --include="*.py" -E "$search_term" $search_dirs 2 } ``` --------- Co-authored-by: Dipika Sikka <[email protected]>
ORDER OF REVIEWS:
Blocked on
#1103
SUMMARY:
main. Class Oneshot consists of pre-processing, carrying out oneshot logic and post-processingEntrypoints:
or
TEST PLAN:
Contingent on #1103, should pass all tests