New footer #1979
Open
New footer #1979
+267
−300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thanks @squiles, code looks good, but it looks like the deployment and other checks like unit tests fail now 😕
bprusinowski
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
LGTM @squiles, thanks!
To fix the knip CI check, you can add a @graphql-tools/schema dependency to app's package.json, I remember doing it a while ago, but maybe it got reversed at some point, we should then have all 🟢 checks :)
|
DO NOT MERGE UNTIL NEXT PRODUCTION DEPLOYMENT IS DONE! |
# Conflicts: # app/locales/de/messages.po # app/locales/en/messages.po # app/locales/fr/messages.po # app/locales/it/messages.po # app/package.json # yarn.lock
noahonyejese
approved these changes
Jan 30, 2025
bprusinowski
force-pushed
the
feat/new-footer
branch
from
5cd3829 to
1602d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New footer from the swiss-federal-ci library