Adding from PEM stack for CA chain functionality #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGonzalezVillal
requested review from
tylerfanelli and
larrydewey
as code owners
|
Can you write a test for |
DGonzalezVillal
force-pushed
the
cert-update
branch
3 times, most recently
from
f930dc1 to
638376c
Compare
|
@tylerfanelli @larrydewey Can you guys review |
|
Seems there's a failing test with |
Turin certs are a different size from previous generation certificates. Adding those certs to our cert cache. When requesting certificates from the KDS, those certificates will come as a pem stack. Adding the ability to generate a ca Chain from a pem stack, that way cert size is not a concern. Also adding testing for this new functionality. Signed-off-by: DGonzalezVillal <[email protected]>
DGonzalezVillal
force-pushed
the
cert-update
branch
from
638376c to
c4e9b81
Compare
|
@tylerfanelli @larrydewey Can you guys review |
tylerfanelli
approved these changes
Nov 18, 2024
| @@ -8,4 +8,7 @@ pub mod genoa; | |||
| /// Milan generation. | |||
| pub mod milan; | |||
|
|
|||
| /// TURIN generation | |||
There was a problem hiding this comment.
Suggested change
| /// TURIN generation | |
| /// Turin generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to create a CA chain from a PEM stack. Will be useful when getting the certificates from the KDS, since that is how those certificates are provided. Will also fix the issue of different cert sizes for different generations.