Fixed testing to have comprehensive testing for the library #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGonzalezVillal
requested review from
tylerfanelli and
larrydewey
as code owners
larrydewey
previously approved these changes
Nov 21, 2024
|
The Turin certificate additions that were originally in #242 are also included in this commit. Can you rebase on main and remove the cert additions? |
Several bugs caught when trying to run cargo test with different feature combinations. Fixed these bugs and made some slight tweaks to be able to run comprehensive testing on the library. - When running cargo test with dangerous_hw_tests enabled both has_sev and has_sev_guest tests were run leading to a failure. Fixed by removing an unecessary or - Renamed has_sev to host and renamed has_sev_guest to guest - ID-BLOCK had to be put behind openssl only - Changed snp_config test to hit only the IOCTL and not modify the config. This was done to avoid messing up system configs during testing. - Renamed the launch test to sev_launch test. This allows us to test that launch test individually. - Added code to create a legacy SEV cert-chain locally. This allows us to test the SEV launch test without the need of an external tool. - Cached Turin certificates to the SEV builtin certs and the SNP builtin certs. Signed-off-by: DGonzalezVillal <[email protected]>
DGonzalezVillal
force-pushed
the
test-fixes
branch
from
542e3b7 to
bce36bb
Compare
mac-os 12 was deprecated by github runners. Bumping to 13. Signed-off-by: DGonzalezVillal <[email protected]>
|
Bumped mac-os version in linter |
There was a problem hiding this comment.
Were these not added in #242 ? Edit: I see the SNP builtin certs were added. Are they different?
| @@ -11,21 +11,31 @@ | |||
| //! An entire certificate chain can be created using the `sevctl` | |||
| //! utility. | |||
|
|
|||
| #[cfg(feature = "sev")] | |||
| use crate::certs::sev::Chain; | |||
| #![cfg(all(feature = "sev", feature = "dangerous_hw_tests"))] | |||
tylerfanelli
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several bugs caught when trying to run cargo test with different feature combinations. Fixed these bugs and made some slight tweaks to be able to run comprehensive testing on the library.