Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor parts of the dataplane #122

Closed
wants to merge 27 commits into from
Closed

refactor parts of the dataplane #122

wants to merge 27 commits into from

Conversation

jcp19
Copy link
Contributor

@jcp19 jcp19 commented Nov 16, 2022

Update:

  • I will not continue this PR for now. Instead, I will refactor the data plane when we have proper support for access modifiers and ghost fields. Nonetheless, some changes from this PR would be worth merging. Furthermore, we should use the gobra std lib when we introduce a package for maps

Milestones:

  • Review usages of map functions everywhere
    • solve completeness problems with the new map encoding
  • Modify the mutex predicate of the dataplane to depend on whether the dataplane is running or not - delete TODO in the code
    • maybe put as a parameter of the router whether it is running or not and move the permission of d.running outside of the predicate?
    • Make the spec of all public methods of the dataplane dependent only on public fields (this should be done for the entire codebase eventually)
  • simplify svc.go, remove wildcards where possible
  • Add triggers everywhere (Review all triggers #101)
  • use more pure functions instead of params to predicate (e.g., for localIA)
  • Activate conditionalize permissions in this branch
  • verify remaining setters
  • drop unecessary ghost params in processPkt (most of them can be inferred, from example, from p.rawPkt)

@jcp19 jcp19 changed the title method Run method Run (memory safety) Nov 29, 2022
@jcp19 jcp19 added the router label Jan 23, 2023
@jcp19 jcp19 changed the title method Run (memory safety) refactor parts of the dataplane Feb 4, 2023
@jcp19 jcp19 linked an issue Feb 5, 2023 that may be closed by this pull request
5 tasks
@jcp19 jcp19 mentioned this pull request Mar 5, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

router/dataplane.go: information hiding and refactoring
1 participant