Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router/dataplane.go: information hiding and refactoring #155

Open
2 of 5 tasks
jcp19 opened this issue Jan 23, 2023 · 0 comments
Open
2 of 5 tasks

router/dataplane.go: information hiding and refactoring #155

jcp19 opened this issue Jan 23, 2023 · 0 comments
Labels
maintainability performance router

Comments

@jcp19
Copy link
Contributor

jcp19 commented Jan 23, 2023 •
edited
Loading

Improvements:

  • drop isComparable from initialization spec
  • drop key field and have a predicate WithKey(key) instead (or a second predicate altogether that reveals the state of the router, while still requiring the dataplaneMutexInvariant to modify the dataplane)
    • instead, implement it as a ghost field
  • drop all wildcards wherever possible (specially in predicates and method spec)
  • use const perm instead of hardcoded permissions everywhere
  • Bring changes from PR refactor parts of the dataplane #122
@jcp19 jcp19 changed the title router/dataplane.go (minor): drop key field and have a predicate WithKey(key) instead router/dataplane.go: information hiding and performance improvements dataplane Jan 24, 2023
@jcp19 jcp19 changed the title router/dataplane.go: information hiding and performance improvements dataplane router/dataplane.go: information hiding and performance improvement Jan 24, 2023
@jcp19 jcp19 linked a pull request Feb 5, 2023 that will close this issue
refactor parts of the dataplane #122
Closed
10 tasks
@jcp19 jcp19 mentioned this issue Mar 5, 2023
Closed
20 tasks
@jcp19 jcp19 changed the title router/dataplane.go: information hiding and performance improvement router/dataplane.go: information hiding Mar 5, 2023
@jcp19 jcp19 self-assigned this Jun 1, 2023
@jcp19 jcp19 removed their assignment Oct 14, 2023
@jcp19 jcp19 changed the title router/dataplane.go: information hiding router/dataplane.go: information hiding and refactoring Dec 12, 2023
@jcp19 jcp19 mentioned this issue Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintainability performance router
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor parts of the dataplane viperproject/VerifiedSCION
1 participant
@jcp19