-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEO #6
Merged
Merged
SEO #6
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4f8e7b9
Add SEO tags
ten1seven 3f5224f
Fix typescript error in GTM code
ten1seven 1777cf1
Updated meta tags
ten1seven 938295b
Rework meta tags
ten1seven d06928f
Working on getting environment URLs working
ten1seven d36bbe2
Update Application.astro
ten1seven 78bc407
Update Application.astro
ten1seven 7dcb768
Add correct URL
ten1seven eb08892
Fix small regression with main > footer layout
ten1seven 9cb012c
Update to use flatMap
ten1seven 37d7514
Add wave background to project list
ten1seven 8faf28d
Add basic 404 page
ten1seven 03def74
Update netlify.toml
ten1seven 1a411eb
Revert "Update netlify.toml"
ten1seven 6731272
Revert "Add basic 404 page"
ten1seven 981754d
Move global styles back into Application.astro
ten1seven 458f343
Update Application.astro
ten1seven 623ee6e
Code refactoring and installed Headwind
ten1seven File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,8 +25,14 @@ const { data: projectData } = await storyblokApi.get('cdn/stories', { | |
|
||
const projects = projectData.stories; | ||
const story = homeData.story; | ||
|
||
// Extract text from the aboutText content | ||
const aboutTextString = story.content.aboutText.content | ||
.map(paragraph => paragraph.content | ||
.map(item => item.text) | ||
.join('')); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You might be able to use flat map here so that there is less nesting. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flatMap It's a subtle change, but more "flat"
|
||
--- | ||
|
||
<Application title="Pointless Corp - The Innovation Lab at Viget"> | ||
<Application title="Pointless Corp - The Innovation Lab at Viget" description={aboutTextString} slug="/"> | ||
<StoryblokComponent blok={story.content} projects={projects} /> | ||
</Application> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was really weird and it even led me to a recent bug report by Henry! Moving this code outside the frontmatter fixed it not wanting to access the env variables.