SEO #6
Merged
SEO #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pointlesscorp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ten1seven
requested review from
andrewmosby,
joshuapease and
nathan-schmidt-viget
ten1seven
commented
Oct 25, 2024
| @@ -41,6 +43,21 @@ import logoLargeWhite from '../images/svgs/pointless-logo-large--white.svg'; | |||
| import iconX from '../images/svgs/x.svg?raw'; | |||
| import '../styles/global.css'; | |||
| --- | |||
| {(() => { | |||
There was a problem hiding this comment.
This was really weird and it even led me to a recent bug report by Henry! Moving this code outside the frontmatter fixed it not wanting to access the env variables.
joshuapease
approved these changes
Oct 28, 2024
src/pages/index.astro
Outdated
Comment on lines
30
to
33
| const aboutTextString = story.content.aboutText.content | ||
| .map(paragraph => paragraph.content | ||
| .map(item => item.text) | ||
| .join('')); |
There was a problem hiding this comment.
You might be able to use flat map here so that there is less nesting.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flatMap
It's a subtle change, but more "flat"
const aboutTextString = story.content.aboutText.content
.flatMap(paragraph => paragraph.content)
.map(item => item.text)
.join('');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting all of the SEO added, Astro/Netlify style: